generated from NHSDigital/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 4
Reduce azure token cache, monitoring and http request logging verbosity #796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
891ddaf to
c914ae1
Compare
|
The review app at this URL has been deleted: |
c914ae1 to
5f0077a
Compare
5f0077a to
e1636be
Compare
e1636be to
02afdda
Compare
02afdda to
ce67079
Compare
ce67079 to
8fa3bd0
Compare
8fa3bd0 to
4f75262
Compare
4f75262 to
a35d80b
Compare
a35d80b to
f740fe6
Compare
1fd4044 to
b91c21f
Compare
b91c21f to
15da69a
Compare
Suppress a lot of DEBUG and some overly verbose INFO level output around azure sdk http requests for monitoring, token retrieval and blob storage operations.
15da69a to
845c8ec
Compare
dnimmo
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We get a lot of debug logging around azure sdk operations which involved http requests, eg. fetching MI tokens or performing blob storage operations, azure monitoring also produces a lot of verbose output.
These are often multiline statements with little value to us in normal running operations.
For the purposes of tracing execution of container apps & jobs these log entries obscure useful messaging so set their log levels to reduce the unneeded output.
eg.:
Jira link
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-11544
Review notes
azure.core.pipeline.policies.http_logging_policyis particularly verbose hence the warning level. At info level we see a lot of request debug output.Review checklist