Skip to content

Small buttons for the medical information page #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MatMoore merged 3 commits into from
Dec 4, 2025
Merged

Small buttons for the medical information page #804

MatMoore merged 3 commits into from
Dec 4, 2025

Conversation

@MatMoore
Copy link
Contributor

@MatMoore MatMoore commented Dec 3, 2025 •
edited
Loading

Description

This upgrades to NHS.UK frontend 10.2.1, and migrates us to small buttons for

  • symptoms
  • medical history
Screenshot of medical history page with small buttons

The presentation of already added symptoms, and the expandable sections will be implemented separately in future PRs.

Jira link

https://nhsd-jira.digital.nhs.uk/browse/DTOSS-11583

Review notes

  • There were some new styles added in 10.2.1 which affect the spacing around summary lists. We discussed on slack here: https://screening-discovery.slack.com/archives/C08R0BT5HH6/p1764773978707519
  • I don't think there are any breaking changes to the macro params that affect us
  • We're missing a form for adding pain as a symptom, so that button is missing. Need to double check we have a ticket for this.
  • I noticed the symptom buttons are singular but the medical history buttons are plural. I've taken the copy directly from the prototype but might want to double check this.

Review checklist

  • Check database queries are correctly scoped to current_provider

@MatMoore MatMoore force-pushed the DTOSS-11583-small-buttons branch from 60cd799 to 63ac2d8 Compare December 3, 2025 16:48
@MatMoore
update nhsuk-frontend to 10.2.2
3a5890c
@MatMoore
change add links to small buttons
a74dea3 
This leaves some empty summary list rows in the medical info summary
list, but this is only a placeholder that we will soon be replacing
with the proper design.

We've added horizontal rules between the summary lists and button groups
because there have been updates to the design system to remove extra
space below summary lists within cards, and these are
conceptually different so need separating a bit.
@MatMoore MatMoore force-pushed the DTOSS-11583-small-buttons branch from 63ac2d8 to 4a22a57 Compare December 4, 2025 11:37
@MatMoore MatMoore force-pushed the DTOSS-11583-small-buttons branch from 4a22a57 to 7596c55 Compare December 4, 2025 11:58
@MatMoore MatMoore marked this pull request as ready for review December 4, 2025 12:05
@MatMoore MatMoore requested a review from a team December 4, 2025 12:05
@MatMoore MatMoore merged commit 9546d02 into main Dec 4, 2025
12 checks passed
@MatMoore MatMoore deleted the DTOSS-11583-small-buttons branch December 4, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlosmartinez carlosmartinez carlosmartinez approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MatMoore @carlosmartinez