remove unwanted participant record page #806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've removed the separate section for participants, so the only way to view a participant now is in the context of an appointment. However, it still might be useful to preserve the /participants/<pk> URL space, as we have some data that is scoped to participant instead of an appointment, and that logically fits at /participant/<pk>. Although we don't link to it directly, the /participants/<pk> URL is still visitable: - when you click on back when visiting any of the URLs nested under it, and the `return_url` query param is missing for any reason - when you go directly to the URL This change is a quick fix that preserves all the existing links, but takes users to the right place if this URL is visited. In the future we might consider improving the back links and potentially migrating all these URLs to live under /mammograms, but I don't want to get bogged down in this now.
MatMoore
changed the title
MatMoore
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some time ago we implemented a participant record page. This no longer exists in the prototype, so we can delete it from the app too.
I came across this while looking at adding in the mammograms section to the record medical information page. The previous mammograms were previously shown on the participant record, and they also show up when you click "View appointment" and go to the participant details.
There are still other views within the
participantsurl namespace (such as the ethnicity form), and in certain edge cases these link back to the participant show view.As a quick fix, I've kept the URLs as they are and made this view redirect to
mammograms:participant_details, which is the new equivalent. It always goes to the latest appointment for the participant, and if there are none (which shouldn't normally happen) it redirects back to the clinics page.Later, we might decide to update all the back links to go directly to the participant details tab, and move the remaining URLs in the participants namespace to the mammograms one, but I don't want to deal with this right now, as my immediate goal is to flesh out the record medical information page, and make sure it has all the right buttons on it.
Jira link
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-11583
Review notes
Review checklist