Skip to content

Conversation

@MatMoore
Copy link
Contributor

@MatMoore MatMoore commented Dec 8, 2025

Description

Since we built the medical history forms in parallel, there's a bit of inconsistency between them. This PR aligns them to a common naming convention:

  • Add/update forms are combined into one class, XYZHistoryItemForm
  • Views are named AddXYZHistoryItemView / UpdateXYZHistoryItemView / DeleteXYZHistoryItemView
  • The various models, forms, and views are grouped into subpackages

Jira link

https://nhsd-jira.digital.nhs.uk/browse/DTOSS-11781

Review notes

Review checklist

  • Check database queries are correctly scoped to current_provider

@MatMoore MatMoore requested a review from a team December 8, 2025 16:51
@MatMoore MatMoore force-pushed the DTOSS-11781-cleanup-medical-history branch from 8a368dd to 0303a5a Compare December 8, 2025 16:53
@swebberuk
Copy link
Contributor

swebberuk commented Dec 9, 2025

Looks good to me. 👍

I did notice record_medical_history.jinja contains "Other breast or chest procedures" and "Non-cancerous lump diagnosis" - I'm not sure if they're required. We also have "Other procedure history" and "Benign lump history", which I think are the ones that are used.

@malcolmbaig malcolmbaig changed the title cleanup medical history - use consistent naming Cleanup medical history - use consistent naming Dec 9, 2025
@MatMoore MatMoore merged commit 640ce42 into main Dec 10, 2025
12 checks passed
@MatMoore MatMoore deleted the DTOSS-11781-cleanup-medical-history branch December 10, 2025 09:20
@MatMoore
Copy link
Contributor Author

Looks good to me. 👍

I did notice record_medical_history.jinja contains "Other breast or chest procedures" and "Non-cancerous lump diagnosis" - I'm not sure if they're required. We also have "Other procedure history" and "Benign lump history", which I think are the ones that are used.

Missed this comment earlier but I'll make sure to remove it in the next PR.

@MatMoore MatMoore mentioned this pull request Dec 10, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants