Show notes on appointment details tab #817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include assertions covering: - the flash message appearing on note save - seeing the saved note rendered on the appointment details tab
MatMoore
approved these changes
Dec 10, 2025
| auditor.audit_create(note) | ||
| else: | ||
| auditor.audit_update(note) | ||
| messages.add_message( |
Contributor
There was a problem hiding this comment.
Design question, but I'm wondering if this success message is unnecessary here.
Instead of redirecting back to the top of the notes tab, we could potentially redirect the user back to the appointment details tab, where the appointment note is visible as a banner.
When I tested the current version, it wasn't obvious to me that the banner was added to the appointment details tab after submitting the form on the notes tab.
|
The review app at this URL has been deleted: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Flash message
Rendered note
Jira link
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-11724
Review notes
na
Review checklist