DTOSS-11923: remove retry queue #865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harriethw
force-pushed
the
dtoss-11923-remove-retry-queue
branch
from
42f8fdf to
041c161
Compare
|
The review app at this URL has been deleted: |
Harriethw
force-pushed
the
dtoss-11923-remove-retry-queue
branch
from
56af6df to
76b6389
Compare
steventux
approved these changes
Jan 5, 2026
Contributor
steventux
left a comment
steventux
left a comment
There was a problem hiding this comment.
I think this is OK, we can reinstate the collect_metrics job if we need it. Better to document and remove than have useless resources like storage queues hanging around.
We no longer need this because we will not be sending messages to Notify
As we are no longer reporting any metrics from notifications.
This includes the alert on queue sizes because there are no more queues
To leave as examples in case code gets deleted/forgotten.
Harriethw
force-pushed
the
dtoss-11923-remove-retry-queue
branch
from
76b6389 to
0d9a65d
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes some of the work originally introduced to collect and alert on metrics such as: #617
As we do not have any queues for the Notifications code anymore
Jira link
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-11923
Review notes
Review checklist