Remove unnecessary null handling

Author: ianfnelson

src/ServiceLayer.Mesh/FileTypes/NbssAppointmentEvents/FileTransformer.cs

@@ -56,7 +56,7 @@ private List<ValidationError> HandleFileParsingException(FileParsingException ex
     private IList<ValidationError> HandleUnexpectedException(Exception ex, MeshFile metaData)
     {
         logger.LogError(ex, "System error occurred while parsing NBSS appointment file. File: {FileName}",
-            metaData?.FileId ?? "Unknown");
+            metaData.FileId);
 
         return
         [

tests/ServiceLayer.Mesh.Tests/FileTransformerTests.cs

@@ -153,28 +153,6 @@ public async Task TransformFileAsync_UnexpectedExceptionThrown_ReturnsSystemVali
             ex => ex == unexpectedException);
     }
 
-    [Fact]
-    public async Task TransformFileAsync_UnexpectedExceptionWithNullMetaData_LogsUnknownFileName()
-    {
-        // Arrange
-        var unexpectedException = new InvalidOperationException("Something went wrong");
-        _fileParserMock.Setup(p => p.Parse(_testStream)).Throws(unexpectedException);
-
-        // Act
-        var result = await _fileTransformer.TransformFileAsync(_testStream, null!);
-
-        // Assert
-        Assert.Single(result);
-        var validationError = result[0];
-        Assert.Equal(ErrorCodes.UnableToParseFile, validationError.Code);
-        Assert.Equal("Unable to parse file", validationError.Error);
-        Assert.Equal(ValidationErrorScope.File, validationError.Scope);
-
-        _loggerMock.VerifyLogger(LogLevel.Error,
-            "System error occurred while parsing NBSS appointment file. File: Unknown",
-            ex => ex == unexpectedException);
-    }
-
     [Fact]
     public async Task TransformFileAsync_ValidationRunnerThrowsException_ReturnsSystemValidationError()
     {