Skip to content
This repository was archived by the owner on Jul 28, 2025. It is now read-only.

Conversation

@ianfnelson
Copy link
Contributor

Description

Added ServiceLayer.Common project, with root namespace of ServiceLayer.
Moved data-related classes into this project, within ServiceLayer.Data
(note that EF model classes are hence in ServiceLayer.Data.Models; this namespace choice was intentional, to denote to devs that these classes represent EF models rather than pure POCOs)

Context

Allows data related functionality to be referenced from both the ServiceLayer.MESH deployable, and also future use such as from ServiceLayer.API

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@ianfnelson ianfnelson merged commit 4683bbb into main May 19, 2025
25 of 26 checks passed
@ianfnelson ianfnelson deleted the refactor/split-data-library-out branch May 19, 2025 07:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants