This repository was archived by the owner on Jul 28, 2025. It is now read-only.
feat: FileParser #19
Merged
feat: FileParser #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unction, refactor tests to match
ianfnelson
suggested changes
May 20, 2025
src/ServiceLayer.Mesh/FileTypes/NbssAppointmentEvents/FileParser.cs
Outdated
Show resolved
Hide resolved
src/ServiceLayer.Mesh/FileTypes/NbssAppointmentEvents/FileParser.cs
Outdated
Show resolved
Hide resolved
src/ServiceLayer.Mesh/FileTypes/NbssAppointmentEvents/FileParser.cs
Outdated
Show resolved
Hide resolved
src/ServiceLayer.Mesh/FileTypes/NbssAppointmentEvents/FileParser.cs
Outdated
Show resolved
Hide resolved
src/ServiceLayer.Mesh/FileTypes/NbssAppointmentEvents/FileParser.cs
Outdated
Show resolved
Hide resolved
tests/ServiceLayer.Mesh.Tests/Functions/FileTransformFunctionTests.cs
Outdated
Show resolved
Hide resolved
src/ServiceLayer.Mesh/FileTypes/NbssAppointmentEvents/FileParser.cs
Outdated
Show resolved
Hide resolved
src/ServiceLayer.Mesh/FileTypes/NbssAppointmentEvents/FileParser.cs
Outdated
Show resolved
Hide resolved
src/ServiceLayer.Mesh/FileTypes/NbssAppointmentEvents/FileParser.cs
Outdated
Show resolved
Hide resolved
src/ServiceLayer.Mesh/FileTypes/NbssAppointmentEvents/Models/FileRecordType.cs
Outdated
Show resolved
Hide resolved
…, used var over int, move rowCount logic, used Linq for ParseColumnHeadings, Removed required attribute from DataRecords property on ParsedFile model
… own classes to use ClassMap
…d move into common project
ianfnelson
suggested changes
May 21, 2025
tests/ServiceLayer.Common.Tests/ServiceLayer.Common.Tests.csproj
Outdated
Show resolved
Hide resolved
src/ServiceLayer.Mesh/FileTypes/NbssAppointmentEvents/Models/FileTrailerRecordMap.cs
Outdated
Show resolved
Hide resolved
src/ServiceLayer.Mesh/FileTypes/NbssAppointmentEvents/Models/FileHeaderRecordMap.cs
Outdated
Show resolved
Hide resolved
ianfnelson
suggested changes
May 21, 2025
src/ServiceLayer.Mesh/FileTypes/NbssAppointmentEvents/FileParser.cs
Outdated
Show resolved
Hide resolved
src/ServiceLayer.Mesh/FileTypes/NbssAppointmentEvents/FileParser.cs
Outdated
Show resolved
Hide resolved
src/ServiceLayer.Mesh/FileTypes/NbssAppointmentEvents/FileParser.cs
Outdated
Show resolved
Hide resolved
src/ServiceLayer.Mesh/FileTypes/NbssAppointmentEvents/FileParser.cs
Outdated
Show resolved
Hide resolved
src/ServiceLayer.Mesh/FileTypes/NbssAppointmentEvents/FileParser.cs
Outdated
Show resolved
Hide resolved
ianfnelson
suggested changes
May 21, 2025
src/ServiceLayer.Mesh/FileTypes/NbssAppointmentEvents/FileParser.cs
Outdated
Show resolved
Hide resolved
tests/ServiceLayer.Mesh.Tests/FileTypes/NbssAppointmentEvents/FileParserTests.cs
Outdated
Show resolved
Hide resolved
alex-clayton-1
previously approved these changes
May 21, 2025
ianfnelson
approved these changes
May 21, 2025
alex-clayton-1
approved these changes
May 21, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FileParser
Context
FileParser
Test
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.