Skip to content
This repository was archived by the owner on Jul 28, 2025. It is now read-only.

Conversation

@ianfnelson
Copy link
Contributor

@ianfnelson ianfnelson commented May 24, 2025

Description

  • Completion of FileTransformFunction
  • Dependency Injection configuration for NBSS appointment event services (in an extension method within NbssAppointmentEvents namespace).
  • Added ValidationErrors field to MeshFile; this maps to an nvarchar(max) in the database.
  • Removed FileExtractFunctionConfiguration - this function should use the Mesh Mailbox ID associated with the file that it is processing, not be tied to the NBSS mailbox ID.
  • Logging of errors returned by MESH .net client - added an extension method to format these errors (our existing code was logging out the class name!)
  • Removed timestamps from information log statements
  • Introduce Test Utilities class library; added some static logger assertions to the same
  • Refactored function unit tests - introduced helper methods and shared base class to reduce duplication.

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@ianfnelson ianfnelson changed the title feat: DTOSS-9179 - transform function completion feat: DTOSS-9179 - Transform function completion, and test/logging refactoring May 27, 2025
@ianfnelson ianfnelson marked this pull request as ready for review May 27, 2025 14:19
@ianfnelson ianfnelson merged commit 784b6f3 into main May 27, 2025
25 of 26 checks passed
@ianfnelson ianfnelson deleted the DTOSS-9179-transform-function-complete branch May 27, 2025 23:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants