Fix: [AEA-4755] - PUT /selectedRole #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wildjames
approved these changes
Feb 3, 2025
kris-szlapa
added a commit
to NHSDigital/eps-prescription-tracker-ui
that referenced
this pull request
Feb 3, 2025
## Summary 🎫 [AEA-4755](https://nhsd-jira.digital.nhs.uk/browse/AEA-4755) PUT /selectedRole 🧪 Regression Tests: NHSDigital/electronic-prescription-service-api-regression-tests#237 👤 Audrey Ricker: 555043304334 `CONFIDENTIAL: PERSONAL PATIENT DATA accessed by RICKER, Audrey - General Medical Practitioner - NO_ORG_NAME (ODS: N82668)` 👤 Curtis Rogers: 555043308597 `CONFIDENTIAL: PERSONAL PATIENT DATA accessed by ROGERS, Curtis - Registration Authority Manager - NO_ORG_NAME (ODS: A21293)` - Routine Change ### Details of the Fix - If the role with access matches `selectedRoleId`, it is added to the `currently_selected_role` but not to the `roles_with_access` array. Move the previously selected role back into rolesWithAccess, but only if it was set. - The RBAC (Role-Based Access Control) User Profile Banner follows these patterns: - Standard user: CONFIDENTIAL: PERSONAL PATIENT DATA accessed by LAST NAME, First Name - RBAC Role - Site Name (ODS: ODS) - Locum user: CONFIDENTIAL: PERSONAL PATIENT DATA accessed by LAST NAME, First Name - RBAC Role - Locum pharmacy (ODS: FFFFF) - Site Name (ODS: ODS Code) - The `confirmButtonText` contains the text: "Continue to find a prescription" --------- Co-authored-by: Sean Steberis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🎫 AEA-4755 PUT /selectedRole Fix
PR NHSDigital/eps-prescription-tracker-ui#384
Details
🧪 Regression tests for the selectedRole lambda fix