Fix: [AEA-4974] - Change role page shows 'No Access' if the 1 role with access is 'selected' #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seansteberisal
previously approved these changes
Feb 4, 2025
…ription-service-api-regression-tests into AEA-4974-change-role-page-shows-no-access
…oles without access
wildjames
requested changes
Feb 6, 2025
|
seansteberisal
approved these changes
Feb 6, 2025
wildjames
approved these changes
Feb 6, 2025
kris-szlapa
added a commit
to NHSDigital/eps-prescription-tracker-ui
that referenced
this pull request
Feb 6, 2025
…th access is 'selected' (#391) ## Summary 🎫 [AEA-4974](https://nhsd-jira.digital.nhs.uk/browse/AEA-4974) Change role page shows 'No Access' if the 1 role with access is 'selected' 🧪 Regression Tests: NHSDigital/electronic-prescription-service-api-regression-tests#239 👤 Katherine McFarland: 555043303526 - Routine Change ### Details The /changerole page is showing the text for 'No access' when a user has: - only 1 role with access - other roles with no access - the role with access is 'selected' **Expected Behaviour** The 'select your role' headers are shown **Observed Behaviour** You are shown the 'No access' header 1 and 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🎫 AEA-4974 PUT /selectedRole Fix
PR https://github.com/NHSDigital/eps-prescription-tracker-ui/pull/394
Details
🧪 Regression tests for the change role page fix
👤 Test User: 555043303526 - Katherine McFarland