Chore: [AEA-0000] - fix behave's override to logging#604
Open
tstephen-nhs wants to merge 1 commit intomainfrom
Open
Chore: [AEA-0000] - fix behave's override to logging#604tstephen-nhs wants to merge 1 commit intomainfrom
tstephen-nhs wants to merge 1 commit intomainfrom
Conversation
tstephen-nhs
temporarily deployed
to
INTERNAL-DEV
GitHub Actions
Inactive
Contributor
|
This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket: AEA-0000 |
tstephen-nhs
temporarily deployed
to
INTERNAL-DEV
GitHub Actions
Inactive
tstephen-nhs
temporarily deployed
to
INTERNAL-DEV
GitHub Actions
Inactive
tstephen-nhs
temporarily deployed
to
INTERNAL-DEV
GitHub Actions
Inactive
tstephen-nhs
temporarily deployed
to
INTERNAL-DEV
GitHub Actions
Inactive
tstephen-nhs
temporarily deployed
to
INTERNAL-DEV
GitHub Actions
Inactive
tstephen-nhs
temporarily deployed
to
INTERNAL-DEV
GitHub Actions
Inactive
tstephen-nhs
temporarily deployed
to
INTERNAL-DEV
GitHub Actions
Inactive
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
Behave before 1.3.0 captures python standard library logging even when
--no-logcaptureis specified as it is in ourrunner.py. This means we cannot use logging statements in steps as currently configured. And consequently this means we have a number of print statements used for logging instead. Note that these print statements too are swallowed as currently configured but can be made to show up if--no-captureis passed to behave (either through direct invocation or my modifyingrunner.py) .This PR re-configures logging after behave is initialised in order to make
--no-logcapturebehave (sic) as advertised.Note that this approach is a stop gap and ideally we should pay down the tech debt to allow ourselves to move to behave 1.3.0 and beyond.