Skip to content

eja - amending make commands to allow for environment specific builds… #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eddalmond1 merged 1 commit into from
Jun 5, 2025
Merged

eja - amending make commands to allow for environment specific builds… #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,9 +127,7 @@ construct-spec: guard-APIM_ENV
mkdir -p build/specification/$(APIM_ENV) && \
npx redocly bundle specification/eligibility-signposting-api.yaml --remove-unused-components --keep-url-references --ext yaml \
> build/specification/$(APIM_ENV)/eligibility-signposting-api.yaml
ifeq ($(APIM_ENV),sandbox)
yq 'del(.components.securitySchemes)' build/specification/sandbox/eligibility-signposting-api.yaml > build/specification/sandbox/eligibility-signposting-api.yaml.tmp && mv build/specification/sandbox/eligibility-signposting-api.yaml.tmp build/specification/sandbox/eligibility-signposting-api.yaml
endif


SPEC_DIR := $(CURDIR)/specification
POSTMAN_DIR := $(SPEC_DIR)/postman
Expand Down
1 change: 1 addition & 0 deletions sandbox/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ update:

spec:
mkdir -p specification
make -C .. construct-spec APIM_ENV=sandbox
make -C .. generate-sandbox-spec

test:
Expand Down
2 changes: 1 addition & 1 deletion specification/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ We deploy our specifications using the Proxygen CLI. In order to do this, the fo
2. Activate a poetry environment `poetry env activate` - you may need to run `make install-python` to install poetry etc. first.
3. Run `make retrieve-proxygen-key` from the root directory to retrieve the private key needed to authenticate with Proxygen.
4. Run `make setup-proxygen-credentials` from the root directory to set up credentials needed to interact with our API proxy.
5. Run `proxygen instance deploy <environment> eligibility-signposting-api ./build/specification/eligibility-signposting-api.yaml` to deploy the specification to
5. Run `proxygen instance deploy <environment> eligibility-signposting-api ./build/specification/<env>/eligibility-signposting-api.yaml` to deploy the specification to
a chosen environment.

### Publishing specifications
Expand Down
2 changes: 1 addition & 1 deletion specification/eligibility-signposting-api.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
openapi: 3.0.1
openapi: 3.0.3
info:
title: Patient Eligibility Signposting API
version: 1.0.10-alpha
Expand Down
Loading