Feature/eli 293 oas updates to align with VitA#23
Merged
eddalmond1 merged 9 commits intomainfrom Jun 18, 2025
Merged
Conversation
Adjusting examples including description Updates to some links in the OAS spec description
Re-adding some accidentally removed new-lines
Furether layout tweaks
Adding specific examples for error conditions to prevent a Postman collection from being generated with additional values in each array.
Reverting to use a separate field for urlLabel (as requested by VitA) and updating some descriptions to confirm that GFM Markdown can be used
jhadfield-NHS
changed the title
Updated to match OAS specification
Adding empty action and suitabilityReason arrays to match development of real code
Adding empty actions and suitabilityRules arrays to match developed codebase.
eddalmond1
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added new attribute of urlLabel to Actions to carry a label to be used for the link/button.
Updated some links in the description to link to our service page (https://digital.nhs.uk/services/eligibility-data-product-elid)
Revised examples to include changes requested by VitA.
Added specific example cases for errors, to prevent a faulty Postman collection being generated.
Context
Adds required adjustments to examples and content samples to support VitA development.
Corrects previously broken links in specification.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.