Skip to content

Feature/oas spec 109 alpha#6

Merged
jhadfield-NHS merged 3 commits intomainfrom
feature/oas-spec-109-alpha
Apr 29, 2025
Merged

Feature/oas spec 109 alpha#6
jhadfield-NHS merged 3 commits intomainfrom
feature/oas-spec-109-alpha

Conversation

@jhadfield-NHS
Copy link
Contributor

Description

Uplifting the OAS specification to 1.0.9-alpha and modifying to fit with environment specific security specification.

Context

APIM directed design adjustments and need for different security mechanism in sandbox.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

Revised to reflect changes recommended by APIM.
Attempt to remediate environment specific security scheme
Attempt to remediate environment specific security
Copy link
Collaborator

@eddalmond1 eddalmond1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I'll check the APIM / Proxygen requirements with regards to security but given it's OAS spec compliant, I can't imagine this doesn't conform to what they want.

@jhadfield-NHS jhadfield-NHS merged commit de26709 into main Apr 29, 2025
37 checks passed
@jhadfield-NHS jhadfield-NHS deleted the feature/oas-spec-109-alpha branch May 13, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants