Skip to content

adding poetry set up #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eddalmond1 merged 6 commits into from
Jul 17, 2025
Merged

adding poetry set up #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
634fffd
adding poetry set up
eddalmond1 Jul 17, 2025
71357ae
bumping python to 3.11 to aid in compatability
eddalmond1 Jul 17, 2025
897ac70
amending lock file for poetry
eddalmond1 Jul 17, 2025
48446d0
splitting out make hooks
eddalmond1 Jul 17, 2025
adb75e3
adding --no-confirm
eddalmond1 Jul 17, 2025
21e6ad3
adding make command to build and publish sandbox
eddalmond1 Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/publish_sandbox.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ jobs:
with:
node-version: '20'

- name: Install Poetry
run: curl -sSL https://install.python-poetry.org | python3 -

- name: Install Python and Node dependencies
run: |
make install
Expand All @@ -50,7 +53,7 @@ jobs:

- name: Deploy sandbox spec to Proxygen
run: |
proxygen instance deploy sandbox eligibility-signposting-api build/specification/sandbox/eligibility-signposting-api.yaml
proxygen instance deploy sandbox eligibility-signposting-api build/specification/sandbox/eligibility-signposting-api.yaml --no-confirm

- name: Build and publish sandbox Docker image
run: |
Expand Down
9 changes: 8 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ install-node:
npm install --legacy-peer-deps

#Condensed Target to run all targets above.
install: install-node install-python .git/hooks/pre-commit
install: install-node install-python

make-hooks: .git/hooks/pre-commit

#Run the npm linting script (specified in package.json). Used to check the syntax and formatting of files.
lint:
Expand Down Expand Up @@ -156,6 +158,11 @@ convert-postman: # Create Postman collection from OAS spec
portman -l /app/eligibility-signposting-api.yaml -o /app/postman/collection.json
echo >> $(POSTMAN_DIR)/collection.json
rm $(POSTMAN_DIR)/eligibility-signposting-api.yaml

build-and-publish-sandbox-image: # Build and publish the sandbox Docker image
$(MAKE) -C sandbox build-and-publish-sandbox-image


# ==============================================================================

${VERBOSE}.SILENT: \
Expand Down
4 changes: 2 additions & 2 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ authors = [
#TODO add authors
]
readme = "README.md"
requires-python = ">=3.13"
requires-python = ">=3.11"
repository = "https://github.com/NHSDigital/eligibility-signposting-api-specification"
homepage = "https://digital.nhs.uk/developer/api-catalogue"
keywords = ["healthcare", "uk", "nhs", "vaccination", "api"] #TODO add additional keywords
Expand All @@ -17,7 +17,7 @@ requires = ["poetry-core>=2.0.0,<3.0.0"]
build-backend = "poetry.core.masonry.api"

[tool.poetry.dependencies]
python = "^3.13"
python = "^3.11"
yq = "^3.2.3"

[tool.poetry.group.dev.dependencies]
Expand Down
Loading