eli-225 adding back in poetry, updating make and readme#7
Conversation
jhadfield-NHS
left a comment
jhadfield-NHS
left a comment
There was a problem hiding this comment.
LGTM
Couple of thoughts/qs, but nothing blocking.
| @@ -1 +1 @@ | |||
| $ref: https://proxygen.ptl.api.platform.nhs.uk/components/securitySchemes/app-level0 | |||
| $ref: https://proxygen.prod.api.platform.nhs.uk/components/securitySchemes/app-level0 | |||
There was a problem hiding this comment.
Ultimately, I think we should remove any auth from the Sandbox version - but I'm not 100% certain.
Does the app-level0 do that for us?
There was a problem hiding this comment.
It doesn't, it requires an API key in the header. I'll remove here and see what the generated specification looks like
There was a problem hiding this comment.
It becomes tricky as we've hardcoded some of the structure in the main spec, and setting an empty value/object/type here fails validation. Best way I can think to do right now is, when we generate the sandbox json file, remove the securityScheme section completely using yq
There was a problem hiding this comment.
Added the change
2 participants
Description
Adding capabilities to construct and publish the specification for different environments.
Context
We need this for interaction with APIM infrastructure
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.