validate approval minimum and maximum

Author: Karthikeyannhs

src/rules_validation_api/validators/campaign_config_validator.py

@@ -9,11 +9,20 @@
 
 
 class CampaignConfigValidation(CampaignConfig):
+
     @field_validator("iterations")
     @classmethod
     def validate_iterations(cls, iterations: list[Iteration]) -> list[IterationValidation]:
         return [IterationValidation(**i.model_dump()) for i in iterations]
 
+    @model_validator(mode="after")
+    def validate_approval_minimum_is_less_than_or_equal_to_approval_maximum(self) -> typing.Self:
+        if self.approval_minimum > self.approval_maximum:
+            raise ValueError(
+                f"approval_minimum {self.approval_minimum} is greater than approval_maximum {self.approval_maximum}"
+            )
+        return self
+
     @model_validator(mode="after")
     def validate_iterations_have_unique_id(self) -> typing.Self:
         ids = [iteration.id for iteration in self.iterations]

tests/unit/validation/test_campaign_config_validator.py

@@ -247,3 +247,29 @@ def test_unique_iteration_ids(self, valid_campaign_config_with_only_mandatory_fi
         # Assert that the duplicate ID appears in the message
         duplicate_id = data["Iterations"][0]["ID"]
         assert f"Iterations contain duplicate IDs: {duplicate_id}" in error_message
+
+
+    def test_error_approval_minimum_is_greater_than_approval_maximum(self, valid_campaign_config_with_only_mandatory_fields):
+        data = valid_campaign_config_with_only_mandatory_fields.copy()
+        data["ApprovalMinimum"] = 2
+        data["ApprovalMaximum"] = 1
+        with pytest.raises(ValidationError):
+            CampaignConfigValidation(**data)
+
+    @pytest.mark.parametrize(
+        ("approval_min", "approval_max"),
+        [
+            (1, 2),
+            (1, 1),
+        ]
+    )
+    def test_approval_minimum_greater_than_approval_maximum_is_invalid(
+        self, valid_campaign_config_with_only_mandatory_fields,
+        approval_min,
+        approval_max,
+    ):
+        data = valid_campaign_config_with_only_mandatory_fields.copy()
+        data["ApprovalMinimum"] = approval_min
+        data["ApprovalMaximum"] = approval_max
+        CampaignConfigValidation(**data)
+