Introduced COHORT_LABEL field in iteration rules #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karthikeyannhs
changed the title
Karthikeyannhs
force-pushed
the
eli-258-introduce_cohort_label_field_in_rules
branch
from
ba8f7b4 to
7f199f3
Compare
Karthikeyannhs
commented
May 23, 2025
|
|
||
| class IterationRuleFactory(ModelFactory[rules.IterationRule]): ... | ||
| class IterationRuleFactory(ModelFactory[rules.IterationRule]): | ||
| attribute_target = None |
Contributor
Author
There was a problem hiding this comment.
no random values will be ret for target_attribute and cohort_label.
ayeshalshukri1-nhs
previously approved these changes
May 27, 2025
| ir | ||
| for ir in iteration_rule_group | ||
| if ir.type in (rules.RuleType.filter, rules.RuleType.suppression) | ||
| and (ir.cohort_label is None or (ir.cohort_label in self.person_cohorts)) |
Contributor
There was a problem hiding this comment.
This looks like it will work for the case of multiple rules, with the same priority, that are executed in an AND
ayeshalshukri1-nhs
approved these changes
May 27, 2025
Contributor
ayeshalshukri1-nhs
left a comment
ayeshalshukri1-nhs
left a comment
There was a problem hiding this comment.
LGTM (reviewed non draft)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.