Skip to content

ELI 204 Update API path as per spec. #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acerathereinspirative-nhs-nvir merged 1 commit into from
May 27, 2025
Merged

ELI 204 Update API path as per spec. #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/eligibility_signposting_api/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def create_app() -> Flask:
logger.info("app created")

# Register views & error handler
app.register_blueprint(eligibility_blueprint, url_prefix="/eligibility")
app.register_blueprint(eligibility_blueprint, url_prefix="/patient-check")
app.register_error_handler(Exception, handle_exception)

# Set up dependency injection using wireup
Expand Down
8 changes: 4 additions & 4 deletions tests/integration/in_process/test_eligibility_endpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ def test_nhs_number_given(client: FlaskClient, persisted_person: NHSNumber, camp
# Given

# When
response = client.get(f"/eligibility/{persisted_person}")
response = client.get(f"/patient-check/{persisted_person}")

# Then
assert_that(
Expand All @@ -26,7 +26,7 @@ def test_no_nhs_number_given(client: FlaskClient):
# Given

# When
response = client.get("/eligibility/")
response = client.get("/patient-check/")

# Then
assert_that(
Expand All @@ -41,7 +41,7 @@ def test_actionable_by_rule(client: FlaskClient, persisted_77yo_person: NHSNumbe
# Given

# When
response = client.get(f"/eligibility/{persisted_77yo_person}")
response = client.get(f"/patient-check/{persisted_77yo_person}")

# Then
assert_that(
Expand All @@ -58,7 +58,7 @@ def test_not_actionable_by_rule(client: FlaskClient, persisted_person: NHSNumber
# Given

# When
response = client.get(f"/eligibility/{persisted_person}")
response = client.get(f"/patient-check/{persisted_person}")

# Then
assert_that(
Expand Down
6 changes: 3 additions & 3 deletions tests/integration/lambda/test_app_running_as_lambda.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def test_install_and_call_lambda_flask(
"http": {
"sourceIp": "192.0.0.1",
"method": "GET",
"path": f"/eligibility/{persisted_person}",
"path": f"/patient-check/{persisted_person}",
"protocol": "HTTP/1.1",
}
},
Expand Down Expand Up @@ -76,7 +76,7 @@ def test_install_and_call_flask_lambda_over_http(
# Given

# When
response = httpx.get(str(flask_function_url / "eligibility" / persisted_person))
response = httpx.get(str(flask_function_url / "patient-check" / persisted_person))

# Then
assert_that(
Expand All @@ -97,7 +97,7 @@ def test_install_and_call_flask_lambda_with_unknown_nhs_number(
nhs_number = NHSNumber(faker.nhs_number())

# When
response = httpx.get(str(flask_function_url / "eligibility" / nhs_number))
response = httpx.get(str(flask_function_url / "patient-check" / nhs_number))

# Then
assert_that(
Expand Down
6 changes: 3 additions & 3 deletions tests/unit/views/test_eligibility.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def test_nhs_number_given(app: Flask, client: FlaskClient):
# Given
with get_app_container(app).override.service(EligibilityService, new=FakeEligibilityService()):
# When
response = client.get("/eligibility/12345")
response = client.get("/patient-check/12345")

# Then
assert_that(
Expand All @@ -56,7 +56,7 @@ def test_no_nhs_number_given(app: Flask, client: FlaskClient):
# Given
with get_app_container(app).override.service(EligibilityService, new=FakeUnknownPersonEligibilityService()):
# When
response = client.get("/eligibility/")
response = client.get("/patient-check/")

# Then
assert_that(
Expand All @@ -81,7 +81,7 @@ def test_no_nhs_number_given(app: Flask, client: FlaskClient):
def test_unexpected_error(app: Flask, client: FlaskClient):
# Given
with get_app_container(app).override.service(EligibilityService, new=FakeUnexpectedErrorEligibilityService()):
response = client.get("/eligibility/12345")
response = client.get("/patient-check/12345")
assert_that(
response,
is_response()
Expand Down
Loading