1st go at adding spike code to the real repo. #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acerathereinspirative-nhs-nvir
force-pushed
the
move-skipe-code-into-real-repo
branch
from
2545f9c to
2642c2b
Compare
acerathereinspirative-nhs-nvir
force-pushed
the
move-skipe-code-into-real-repo
branch
from
e31bcfe to
6316350
Compare
acerathereinspirative-nhs-nvir
force-pushed
the
move-skipe-code-into-real-repo
branch
2 times, most recently
from
83d8d32 to
95eb81d
Compare
acerathereinspirative-nhs-nvir
force-pushed
the
move-skipe-code-into-real-repo
branch
from
95eb81d to
376ad46
Compare
acerathereinspirative-nhs-nvir
force-pushed
the
move-skipe-code-into-real-repo
branch
from
0c47338 to
e14e6ff
Compare
…ng it directly from boto.
…ng it directly from boto.
acerathereinspirative-nhs-nvir
force-pushed
the
move-skipe-code-into-real-repo
branch
from
2d7c1df to
11b0f8f
Compare
acerathereinspirative-nhs-nvir
force-pushed
the
move-skipe-code-into-real-repo
branch
from
37f2895 to
fae4d9c
Compare
acerathereinspirative-nhs-nvir
force-pushed
the
move-skipe-code-into-real-repo
branch
2 times, most recently
from
843b5bd to
4d44ec5
Compare
acerathereinspirative-nhs-nvir
force-pushed
the
move-skipe-code-into-real-repo
branch
from
4d44ec5 to
8bf173d
Compare
eddalmond1
reviewed
Mar 12, 2025
pyproject.toml
Outdated
| [tool.ruff.lint] | ||
| select = ["ALL"] | ||
| ignore = ["COM812", "D"] | ||
| ignore = ["COM812", "D", "PGH003"] |
Collaborator
There was a problem hiding this comment.
It's more cumbersome to include the specific type warnings, so I can understand why we might want to allow the blanket ignore, but I'd like to keep an eye on usage :D
Contributor
Author
There was a problem hiding this comment.
I agree.
Good spot - this one can be removed now BTW.
Contributor
Author
There was a problem hiding this comment.
It's specifically recommended to ignore COM812 if you are using ruff's formatting, which we are.
The "D" rules, on the other hand, we might want to discuss. Do we want to require docstrings on all classes and functions?
Karthikeyannhs
approved these changes
Mar 12, 2025
eddalmond1
approved these changes
Mar 12, 2025
Collaborator
eddalmond1
left a comment
eddalmond1
left a comment
There was a problem hiding this comment.
Looks good - happy this represents what we saw in the spike but with some nice additions to our workflows
acerathereinspirative-nhs-nvir
deleted the
move-skipe-code-into-real-repo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.