eli-176 adding an 'example' serving proxy which leverages Prisms 'example' and 'code' params #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… causing validation errors in the sandbox
…xtending-prism-for-sandbox
…tidying and tests adding!
…dating make commands
eddalmond1
changed the base branch from
feature/eja-eli-98-using-prism-for-sandbox
to
main
Contributor
|
Are we missing the |
Collaborator
Author
make spec should be making that from /specification/eligibility-signposting-api.yaml, so one to debug (as it's a classic 'working on my machine' scenario!) |
eddalmond1
commented
Mar 14, 2025
…ing port 9000 (which is used by our example proxy)
eddalmond1
changed the title
… sonarcube coverage does anything
acerathereinspirative-nhs-nvir
previously approved these changes
Mar 25, 2025
Contributor
acerathereinspirative-nhs-nvir
left a comment
acerathereinspirative-nhs-nvir
left a comment
There was a problem hiding this comment.
LGTM.
…xtending-prism-for-sandbox
acerathereinspirative-nhs-nvir
previously approved these changes
Mar 25, 2025
Contributor
acerathereinspirative-nhs-nvir
left a comment
acerathereinspirative-nhs-nvir
left a comment
There was a problem hiding this comment.
LGTM.
Contributor
acerathereinspirative-nhs-nvir
left a comment
acerathereinspirative-nhs-nvir
left a comment
There was a problem hiding this comment.
Still looks good to me! 🤣
acerathereinspirative-nhs-nvir
previously approved these changes
Mar 25, 2025
acerathereinspirative-nhs-nvir
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding functionality for https://github.com/stoplightio/ExampleChooserPrismProxy to the prism implementation of a sandbox. The changes here basically set up a proxy for the main Prism service, so that specific example values used in requests are parsed into arguments (example= , code= ) that Prism uses to serve specific responses based on those held in the specification.
Context
This change allows us to 'push' the prefer hints to prism via request content
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.