Skip to content

Feature/eli 216 nhs number matching#189

Merged
Karthikeyannhs merged 10 commits intomainfrom
feature/eli-216-nhs_number_matching
Jun 25, 2025
Merged

Feature/eli 216 nhs number matching#189
Karthikeyannhs merged 10 commits intomainfrom
feature/eli-216-nhs_number_matching

Conversation

@robbailiff2
Copy link
Contributor

Description

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@robbailiff2 robbailiff2 marked this pull request as draft June 24, 2025 14:47
@Karthikeyannhs Karthikeyannhs marked this pull request as ready for review June 25, 2025 01:09
@Karthikeyannhs Karthikeyannhs requested a review from TOEL2 June 25, 2025 10:32
- DEBUG=${LOCALSTACK_DEBUG:-0}
- DEFAULT_REGION=${AWS_DEFAULT_REGION:-eu-west-1}
- LAMBDA_EXECUTOR=docker
- LAMBDA_EXECUTOR=local
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work on WSL and MacOS ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ayeshalshukri1-nhs , we just rechecked it is working in both the machines.

Copy link
Contributor

@ayeshalshukri1-nhs ayeshalshukri1-nhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Karthikeyannhs Karthikeyannhs merged commit bfa9629 into main Jun 25, 2025
22 checks passed
@Karthikeyannhs Karthikeyannhs deleted the feature/eli-216-nhs_number_matching branch July 1, 2025 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants