Skip to content

Conversation

@ivma1-nhs
Copy link
Contributor

Description

This PR introduces improvements to the CI workflow and test infrastructure by adding integration test result collection, reporting, and improved test command parameters.

Specifically:

  • Integration test results are now uploaded as artifacts during the GitHub Actions workflow.
  • Summaries of test results are gathered and reported using phoenix-actions/test-reporting.
  • Integration test execution has been updated to output JUnit XML for CI consumption.
  • The retry logic in conftest.py has been enhanced with custom retry attempts and timeout parameters for better test stability.

Context

These changes aim to improve test result visibility in CI and make integration tests more robust and maintainable. With test artifacts and reports now being part of the workflow, it becomes easier to debug failures and understand test performance over time. The retry logic update addresses potential flakiness in Lambda function availability during test runs.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the [contributing guidelines](../docs/CONTRIBUTING.md)
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ivma1-nhs ivma1-nhs merged commit 4acd63f into main Mar 25, 2025
36 checks passed
@eddalmond1 eddalmond1 deleted the test-integration_report_with_commit_signed branch May 21, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants