ELI-152 Implement full list of available operators for the Rule Engine #49
+797
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acerathereinspirative-nhs-nvir
approved these changes
Apr 23, 2025
Contributor
acerathereinspirative-nhs-nvir
left a comment
acerathereinspirative-nhs-nvir
left a comment
There was a problem hiding this comment.
Looks good for now.
eddalmond1
reviewed
Apr 23, 2025
Collaborator
eddalmond1
left a comment
eddalmond1
left a comment
There was a problem hiding this comment.
Good, I've only spotted one potential edge case but mostly looks like what we'd want.
src/eligibility_signposting_api/services/eligibility_services.py
Outdated
Show resolved
Hide resolved
acerathereinspirative-nhs-nvir
requested changes
Apr 23, 2025
Contributor
acerathereinspirative-nhs-nvir
left a comment
acerathereinspirative-nhs-nvir
left a comment
There was a problem hiding this comment.
Please fix linting errors!
acerathereinspirative-nhs-nvir
previously approved these changes
Apr 23, 2025
eddalmond1
approved these changes
Apr 23, 2025
Collaborator
eddalmond1
left a comment
eddalmond1
left a comment
There was a problem hiding this comment.
Looks good, approved, with the assumption Simon's concerns will be addressed in a subsequent ticket
ayeshalshukri1-nhs
force-pushed
the
feature/eli-152-operators-impl
branch
from
be60a1c to
e2f845e
Compare
Contributor
|
. |
Contributor
There was a problem hiding this comment.
Just thinking, will it be better to group the testscases for a same operator together using test classes for better structuring?
Contributor
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AS A developer
I WANT to add a full list of operators from DPS to the rule engine
SO THAT they are available for use in eligibility checks
https://nhsd-jira.digital.nhs.uk/browse/ELI-152
Context
The task here is to compile/transfer a full list of available operators from DPS and implement them for the rule engine.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.