Feature/eja eli 204 add api gateway #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k response for _status
Collaborator
Author
|
TO DO:
|
Karthikeyannhs
previously approved these changes
May 7, 2025
Contributor
|
Approved! :) |
…gration with API Gateway (first attempt)
eddalmond1
commented
May 29, 2025
| resource "aws_lambda_permission" "get_patient_check" { | ||
| statement_id = "AllowExecutionFromAPIGateway" | ||
| action = "lambda:InvokeFunction" | ||
| function_name = module.eligibility_signposting_lambda_function.aws_lambda_function_name # placeholder for the actual lambda function name |
Collaborator
Author
There was a problem hiding this comment.
get rid of this comment
TOEL2
approved these changes
May 29, 2025
Contributor
TOEL2
left a comment
TOEL2
left a comment
There was a problem hiding this comment.
Walked through changes with Edd and Rob, looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added in an API Gateway resource, along with method definition, cloudwatch logging and ability to invoke a lambda.
NOTE - this code needs the Lambda details editing in the config once this is in place
Also fixed a cross-stack dependency, as we want to deploy just the config in our stack.
Context
We need this for our full stack.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.