ELI-205 : Configure provision lambda #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karthikeyannhs
force-pushed
the
feature/ash-kt-eli-205-configure-provision-lambda
branch
from
dc734df to
4f787a4
Compare
Karthikeyannhs
force-pushed
the
feature/ash-kt-eli-205-configure-provision-lambda
branch
from
4f787a4 to
885db77
Compare
Karthikeyannhs
changed the title
acerathereinspirative-nhs-nvir
requested changes
May 13, 2025
Contributor
acerathereinspirative-nhs-nvir
left a comment
acerathereinspirative-nhs-nvir
left a comment
There was a problem hiding this comment.
A few tweaks suggested, and I'd like to see ENV explained in the README.
Co-authored-by: Simon B <[email protected]>
Co-authored-by: Simon B <[email protected]>
Co-authored-by: Simon B <[email protected]>
Co-authored-by: Simon B <[email protected]>
Co-authored-by: Simon B <[email protected]>
eddalmond1
reviewed
May 13, 2025
eddalmond1
reviewed
May 13, 2025
eddalmond1
reviewed
May 13, 2025
eddalmond1
reviewed
May 13, 2025
eddalmond1
reviewed
May 13, 2025
eddalmond1
reviewed
May 13, 2025
eddalmond1
reviewed
May 13, 2025
eddalmond1
reviewed
May 13, 2025
eddalmond1
reviewed
May 13, 2025
eddalmond1
reviewed
May 13, 2025
eddalmond1
reviewed
May 13, 2025
Collaborator
eddalmond1
left a comment
eddalmond1
left a comment
There was a problem hiding this comment.
Done an initial review, made a few comments, mostly trivial changes / suggestions / questions. Looks good!
eddalmond1
approved these changes
May 13, 2025
Collaborator
eddalmond1
left a comment
eddalmond1
left a comment
There was a problem hiding this comment.
Approved from a TF point of view :D
acerathereinspirative-nhs-nvir
approved these changes
May 13, 2025
Karthikeyannhs
deleted the
feature/ash-kt-eli-205-configure-provision-lambda
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.