Skip to content

Test for mulitple campaigns #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Karthikeyannhs merged 2 commits into from
May 14, 2025
Merged

Test for mulitple campaigns #87

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9dc2c04
Add test for multiple campaigns with multiple conditions.
Karthikeyannhs May 14, 2025
5b2734a
Add test for multiple campaigns with the same condition.
Karthikeyannhs May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
139 changes: 137 additions & 2 deletions tests/unit/services/test_eligibility_services.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,17 @@
import pytest
from faker import Faker
from freezegun import freeze_time
from hamcrest import assert_that, empty, has_item
from hamcrest import assert_that, contains_exactly, empty, has_item, has_items

from eligibility_signposting_api.model.eligibility import ConditionName, DateOfBirth, NHSNumber, Postcode, Status
from eligibility_signposting_api.model.rules import IterationDate, IterationRule, RuleComparator, RulePriority, RuleType
from eligibility_signposting_api.model.rules import (
CampaignConfig,
IterationDate,
IterationRule,
RuleComparator,
RulePriority,
RuleType,
)
from eligibility_signposting_api.repos import EligibilityRepo, NotFoundError, RulesRepo
from eligibility_signposting_api.services import EligibilityService, UnknownPersonError
from tests.fixtures.builders.model import rule as rule_builder
Expand Down Expand Up @@ -480,3 +487,131 @@ def test_rules_with_same_priority_must_all_match_to_exclude(
),
test_comment,
)


def test_multiple_conditions(faker: Faker):
# Given
nhs_number = NHSNumber(f"5{faker.random_int(max=999999999):09d}")
date_of_birth = DateOfBirth(faker.date_of_birth(minimum_age=76, maximum_age=78))

eligibility_repo = MagicMock(spec=EligibilityRepo)
rules_repo = MagicMock(spec=RulesRepo)

eligibility_repo.get_eligibility_data = MagicMock(
return_value=eligibility_rows_builder(nhs_number, date_of_birth=date_of_birth, cohorts=["cohort1"])
)
rules_repo.get_campaign_configs = MagicMock(
return_value=[
rule_builder.CampaignConfigFactory.build(
target="RSV",
iterations=[
rule_builder.IterationFactory.build(
iteration_cohorts=[rule_builder.IterationCohortFactory.build(cohort_label="cohort1")],
iteration_rules=[rule_builder.PersonAgeSuppressionRuleFactory.build()],
)
],
),
rule_builder.CampaignConfigFactory.build(
target="COVID",
iterations=[
rule_builder.IterationFactory.build(
iteration_cohorts=[rule_builder.IterationCohortFactory.build(cohort_label="cohort1")],
iteration_rules=[rule_builder.PersonAgeSuppressionRuleFactory.build()],
)
],
),
]
)

service = EligibilityService(eligibility_repo, rules_repo)

# When
actual = service.get_eligibility_status(NHSNumber(nhs_number))

# Then
assert_that(
actual,
is_eligibility_status().with_conditions(
has_items(
is_condition().with_condition_name(ConditionName("RSV")).and_status(Status.actionable),
is_condition().with_condition_name(ConditionName("COVID")).and_status(Status.actionable),
)
),
)


@pytest.mark.parametrize(
("test_comment", "campaign1", "campaign2"),
[
(
"1st campaign allows, 2nd excludes",
rule_builder.CampaignConfigFactory.build(
target="RSV",
iterations=[
rule_builder.IterationFactory.build(
iteration_cohorts=[rule_builder.IterationCohortFactory.build(cohort_label="cohort1")],
iteration_rules=[rule_builder.PersonAgeSuppressionRuleFactory.build()],
)
],
),
rule_builder.CampaignConfigFactory.build(
target="RSV",
iterations=[
rule_builder.IterationFactory.build(
iteration_cohorts=[rule_builder.IterationCohortFactory.build(cohort_label="cohort1")],
iteration_rules=[rule_builder.PersonAgeSuppressionRuleFactory.build(comparator="-85")],
)
],
),
),
(
"1st campaign excludes, 2nd allows",
rule_builder.CampaignConfigFactory.build(
target="RSV",
iterations=[
rule_builder.IterationFactory.build(
iteration_cohorts=[rule_builder.IterationCohortFactory.build(cohort_label="cohort1")],
iteration_rules=[rule_builder.PersonAgeSuppressionRuleFactory.build(comparator="-85")],
)
],
),
rule_builder.CampaignConfigFactory.build(
target="RSV",
iterations=[
rule_builder.IterationFactory.build(
iteration_cohorts=[rule_builder.IterationCohortFactory.build(cohort_label="cohort1")],
iteration_rules=[rule_builder.PersonAgeSuppressionRuleFactory.build()],
)
],
),
),
],
)
def test_multiple_campaigns_for_single_condition(
test_comment: str, campaign1: CampaignConfig, campaign2: CampaignConfig, faker: Faker
):
# Given
nhs_number = NHSNumber(f"5{faker.random_int(max=999999999):09d}")
date_of_birth = DateOfBirth(faker.date_of_birth(minimum_age=76, maximum_age=78))

eligibility_repo = MagicMock(spec=EligibilityRepo)
rules_repo = MagicMock(spec=RulesRepo)

eligibility_repo.get_eligibility_data = MagicMock(
return_value=eligibility_rows_builder(nhs_number, date_of_birth=date_of_birth, cohorts=["cohort1"])
)
rules_repo.get_campaign_configs = MagicMock(return_value=[campaign1, campaign2])

service = EligibilityService(eligibility_repo, rules_repo)

# When
actual = service.get_eligibility_status(NHSNumber(nhs_number))

# Then
assert_that(
actual,
is_eligibility_status().with_conditions(
contains_exactly(is_condition().with_condition_name(ConditionName("RSV")).and_status(Status.actionable))
),
test_comment,
)
Loading