Skip to content

Conversation

@Karthikeyannhs
Copy link
Contributor

@Karthikeyannhs Karthikeyannhs commented May 16, 2025

Description

This code contains setting dynamic names to the roles and keys which are part of api-layer.
✅1. Mulitple workspaces can be created in the stack api-layer
✅2. Only default is allowed in the stacks such as networking, iam-developer roles

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

eddalmond1
eddalmond1 previously approved these changes May 19, 2025
Copy link
Collaborator

@eddalmond1 eddalmond1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, understand the rationale, so approved

@Karthikeyannhs Karthikeyannhs merged commit d2140fe into main May 20, 2025
24 checks passed
@eddalmond1 eddalmond1 deleted the clean-up/terraform-code-cleanup branch May 21, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants