Skip to content

eligibility calculator code refactor #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Karthikeyannhs merged 2 commits into from
May 20, 2025
+3 −7
Merged

eligibility calculator code refactor #94

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
118e74a
removed redundant if condition and corrected comments
Karthikeyannhs May 19, 2025
89627a4
lint fixed
Karthikeyannhs May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions src/eligibility_signposting_api/services/calculators/eligibility_calculator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,7 @@ def get_the_base_eligible_campaigns(self, campaign_group: list[rules.CampaignCon
"""Return campaigns for which the person is base eligible via cohorts."""

base_eligible_campaigns: list[rules.CampaignConfig] = [
campaign
for campaign in campaign_group
if campaign.campaign_live
and campaign.current_iteration
and self.check_base_eligibility(campaign.current_iteration)
campaign for campaign in campaign_group if self.check_base_eligibility(campaign.current_iteration)
]

if base_eligible_campaigns:
Expand All @@ -91,8 +87,8 @@ def check_base_eligibility(self, iteration: rules.Iteration | None) -> set[str]:
def evaluate_eligibility_by_iteration_rules(
self, campaign_group: list[rules.CampaignConfig]
) -> tuple[eligibility.Status, list[eligibility.Reason]]:
"""Evaluate iteration rules to see if the person is actionable, not actionable (due to "F" rules),
or not eligible (due to "S" rules").
"""Evaluate iteration rules to see if the person is actionable, not actionable (due to "S" rules),
or not eligible (due to "F" rules").

For each condition, evaluate all iterations for inclusion or exclusion."""

Expand Down
Loading