Already vaccinated scenarios covered #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
acerathereinspirative-nhs-nvir
left a comment
acerathereinspirative-nhs-nvir
left a comment
There was a problem hiding this comment.
Some comments...
| de: bool | None = ..., | ||
| msoa: str | None = ..., | ||
| lsoa: str | None = ..., | ||
| last_successful_date: str = "", |
Contributor
There was a problem hiding this comment.
We'd like to be able to set different dates for different vaccines. I was thinking that you'd set the vaccines parameter here - I don't think this builder needs any changes at all.
| comparator = rules.RuleComparator("QE1") | ||
|
|
||
|
|
||
| class TargetAlreadyVaccinatedSuppressionRuleFactory(IterationRuleFactory): |
Contributor
There was a problem hiding this comment.
We shouldn't spam out loads of these specialised builders. PersonAgeSuppressionRuleFactory is there because it's used many times. If we are only using this once, we can just use the IterationRuleFactory directly.
…ility_calculator.py Co-authored-by: Simon B <[email protected]>
…services/calculators/test_eligibility_calculator.py Co-authored-by: Simon B <[email protected]>
acerathereinspirative-nhs-nvir
requested changes
May 21, 2025
acerathereinspirative-nhs-nvir
approved these changes
May 21, 2025
Contributor
acerathereinspirative-nhs-nvir
left a comment
acerathereinspirative-nhs-nvir
left a comment
There was a problem hiding this comment.
As long as we get the aforementioned test before the story is done, I'm happy for this to be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.