Add more tests to suits

Author: kris-szlapa

packages/slackBotFunction/tests/test_async_processing.py

@@ -364,3 +364,47 @@ def test_process_async_slack_event_post_error_message_fails(mock_boto_resource,
 
         # Should not raise exception even when error posting fails
         process_async_slack_event(slack_event_data)
+
+
+@patch("slack_bolt.App")
+@patch("aws_lambda_powertools.utilities.parameters.get_parameter")
+@patch("boto3.resource")
+def test_process_async_slack_event_dm_context(mock_boto_resource, mock_get_parameter, mock_app, mock_env):
+    """Test process_async_slack_event with DM context"""
+    mock_get_parameter.side_effect = [
+        json.dumps({"token": "test-token"}),
+        json.dumps({"secret": "test-secret"}),
+    ]
+    mock_boto_resource.return_value.Table.return_value = Mock()
+
+    if "app.slack.slack_events" in sys.modules:
+        del sys.modules["app.slack.slack_events"]
+
+    with patch("slack_sdk.WebClient") as mock_webclient, patch(
+        "app.slack.slack_events.query_bedrock"
+    ) as mock_bedrock, patch("app.slack.slack_events.get_conversation_session") as mock_get_session, patch(
+        "boto3.client"
+    ):
+
+        mock_client = Mock()
+        mock_client.chat_postMessage.return_value = {"ts": "123"}
+        mock_webclient.return_value = mock_client
+
+        mock_bedrock.return_value = {"output": {"text": "AI response"}, "sessionId": "new-session"}
+        mock_get_session.return_value = None
+
+        from app.slack.slack_events import process_async_slack_event
+
+        slack_event_data = {
+            "event": {
+                "text": "test question",
+                "user": "U456",
+                "channel": "D789",
+                "ts": "123",
+                "channel_type": "im",  # DM context
+            },
+            "event_id": "evt123",
+            "bot_token": "bot-token",
+        }
+
+        process_async_slack_event(slack_event_data)

packages/slackBotFunction/tests/test_feedback.py

@@ -180,3 +180,38 @@ def test_cleanup_previous_unfeedback_qa_error_handling(mock_table, mock_env):
     with patch("app.slack.slack_events.check_feedback_exists", side_effect=Exception("Error")):
         # Should not raise exception
         cleanup_previous_unfeedback_qa("conv-key", "123", session_data)
+
+
+@patch("app.slack.slack_events.table")
+def test_get_conversation_session_data_no_item(mock_table, mock_env):
+    """Test get_conversation_session_data when no item exists"""
+    mock_table.get_item.return_value = {}  # No Item key
+    from app.slack.slack_events import get_conversation_session_data
+
+    result = get_conversation_session_data("test-key")
+    assert result is None
+
+
+@patch("app.slack.slack_events.table")
+def test_get_latest_message_ts_no_item(mock_table, mock_env):
+    """Test get_latest_message_ts when no item exists"""
+    mock_table.get_item.return_value = {}  # No Item key
+    from app.slack.slack_events import get_latest_message_ts
+
+    result = get_latest_message_ts("test-key")
+    assert result is None
+
+
+@patch("app.slack.slack_events.table")
+def test_store_feedback_client_error_reraise(mock_table, mock_env):
+    """Test store_feedback re-raises ClientError"""
+    from botocore.exceptions import ClientError
+
+    error = ClientError({"Error": {"Code": "ValidationException"}}, "PutItem")
+    mock_table.put_item.side_effect = error
+
+    from app.slack.slack_events import store_feedback
+
+    with patch("app.slack.slack_events.get_latest_message_ts", return_value="123"):
+        with pytest.raises(ClientError):
+            store_feedback("conv-key", "query", "positive", "user-id", "channel-id")

packages/slackBotFunction/tests/test_slack_handlers.py

@@ -472,3 +472,42 @@ def test_app_mention_handler_normal_mention(mock_env):
     ) as mock_trigger:
         app_mention_handler(mock_event, mock_ack, mock_body, mock_client)
         mock_trigger.assert_called_once()
+
+
+def test_feedback_handler_conditional_check_failed(mock_env):
+    """Test feedback_handler with ConditionalCheckFailedException"""
+    from app.slack.slack_handlers import feedback_handler
+    from botocore.exceptions import ClientError
+
+    mock_ack = Mock()
+    mock_body = {
+        "user": {"id": "U123"},
+        "actions": [{"action_id": "feedback_yes", "value": '{"ck": "conv-key", "mt": "123"}'}],
+    }
+    mock_client = Mock()
+
+    error = ClientError({"Error": {"Code": "ConditionalCheckFailedException"}}, "PutItem")
+
+    with patch("app.slack.slack_handlers._is_latest_message", return_value=True), patch(
+        "app.slack.slack_handlers.store_feedback", side_effect=error
+    ):
+        feedback_handler(mock_ack, mock_body, mock_client)
+        mock_ack.assert_called_once()
+
+
+def test_feedback_handler_storage_error(mock_env):
+    """Test feedback_handler with storage error"""
+    from app.slack.slack_handlers import feedback_handler
+
+    mock_ack = Mock()
+    mock_body = {
+        "user": {"id": "U123"},
+        "actions": [{"action_id": "feedback_yes", "value": '{"ck": "conv-key", "mt": "123"}'}],
+    }
+    mock_client = Mock()
+
+    with patch("app.slack.slack_handlers._is_latest_message", return_value=True), patch(
+        "app.slack.slack_handlers.store_feedback", side_effect=Exception("Storage error")
+    ):
+        feedback_handler(mock_ack, mock_body, mock_client)
+        mock_ack.assert_called_once()