Skip to content

Commit 47c7690

Browse files
committed
Remove the unused function parameter body
1 parent e8e3298 commit 47c7690

File tree

2 files changed

+9
-14
lines changed

2 files changed

+9
-14
lines changed

packages/slackBotFunction/app/slack/slack_handlers.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ def app_mention_handler(event, ack, body, client):
138138
_trigger_async_processing({"event": event, "event_id": event_id, "bot_token": bot_token})
139139

140140

141-
def dm_message_handler(event, event_id, body, client):
141+
def dm_message_handler(event, event_id, client):
142142
"""
143143
Direct messages:
144144
- 'feedback:' prefix -> store as conversation-scoped additional feedback (no model call).
@@ -183,7 +183,7 @@ def dm_message_handler(event, event_id, body, client):
183183
_trigger_async_processing({"event": event, "event_id": event_id, "bot_token": bot_token})
184184

185185

186-
def channel_message_handler(event, event_id, body, client):
186+
def channel_message_handler(event, event_id, client):
187187
"""
188188
Channel messages:
189189
- Ignore top-level messages (policy: require @mention to start).
@@ -253,10 +253,10 @@ def unified_message_handler(event, ack, body, client):
253253
# Route to appropriate handler based on message type
254254
if event.get("channel_type") == CHANNEL_TYPE_IM:
255255
# DM handling
256-
dm_message_handler(event, event_id, body, client)
256+
dm_message_handler(event, event_id, client)
257257
else:
258258
# Channel message handling
259-
channel_message_handler(event, event_id, body, client)
259+
channel_message_handler(event, event_id, client)
260260

261261

262262
def feedback_handler(ack, body, client):

packages/slackBotFunction/tests/test_slack_handlers.py

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -373,11 +373,10 @@ def test_dm_message_handler_feedback_error_handling(mock_env):
373373

374374
mock_client = Mock()
375375
mock_event = {"text": "feedback: DM feedback", "user": "U456", "channel": "D789", "ts": "123", "channel_type": "im"}
376-
mock_body = {"event_id": "evt123"}
377376

378377
with patch("app.slack.slack_handlers.store_feedback_with_qa") as mock_store:
379378
mock_store.side_effect = Exception("Storage failed")
380-
dm_message_handler(mock_event, "evt123", mock_body, mock_client)
379+
dm_message_handler(mock_event, "evt123", mock_client)
381380
mock_client.chat_postMessage.assert_called_once()
382381

383382

@@ -387,12 +386,11 @@ def test_channel_message_handler_session_check_error(mock_env):
387386

388387
mock_client = Mock()
389388
mock_event = {"text": "follow up", "channel": "C789", "thread_ts": "123", "user": "U456"}
390-
mock_body = {"event_id": "evt123"}
391389

392390
with patch("app.core.config.table") as mock_table:
393391
mock_table.get_item.side_effect = Exception("DB error")
394392
# Should return early due to error
395-
channel_message_handler(mock_event, "evt123", mock_body, mock_client)
393+
channel_message_handler(mock_event, "evt123", mock_client)
396394

397395

398396
def test_feedback_handler_unknown_action(mock_env):
@@ -426,11 +424,10 @@ def test_channel_message_handler_no_session(mock_env):
426424

427425
mock_client = Mock()
428426
mock_event = {"text": "follow up", "channel": "C789", "thread_ts": "123", "user": "U456"}
429-
mock_body = {"event_id": "evt123"}
430427

431428
with patch("app.core.config.table") as mock_table:
432429
mock_table.get_item.return_value = {} # No session
433-
channel_message_handler(mock_event, "evt123", mock_body, mock_client)
430+
channel_message_handler(mock_event, "evt123", mock_client)
434431

435432

436433
def test_channel_message_handler_feedback_path(mock_env):
@@ -439,12 +436,11 @@ def test_channel_message_handler_feedback_path(mock_env):
439436

440437
mock_client = Mock()
441438
mock_event = {"text": "feedback: channel feedback", "channel": "C789", "thread_ts": "123", "user": "U456"}
442-
mock_body = {"event_id": "evt123"}
443439

444440
with patch("app.core.config.table") as mock_table:
445441
mock_table.get_item.return_value = {"Item": {"session_id": "session123"}}
446442
# Just test that the function runs without error
447-
channel_message_handler(mock_event, "evt123", mock_body, mock_client)
443+
channel_message_handler(mock_event, "evt123", mock_client)
448444

449445

450446
def test_dm_message_handler_normal_message(mock_env):
@@ -453,10 +449,9 @@ def test_dm_message_handler_normal_message(mock_env):
453449

454450
mock_client = Mock()
455451
mock_event = {"text": "normal message", "user": "U456", "channel": "D789", "ts": "123", "channel_type": "im"}
456-
mock_body = {"event_id": "evt123"}
457452

458453
with patch("app.slack.slack_handlers._trigger_async_processing") as mock_trigger:
459-
dm_message_handler(mock_event, "evt123", mock_body, mock_client)
454+
dm_message_handler(mock_event, "evt123", mock_client)
460455
mock_trigger.assert_called_once()
461456

462457

0 commit comments

Comments
 (0)