Add tests for feedback logic

Author: kris-szlapa

packages/slackBotFunction/tests/test_feedback.py

@@ -171,6 +171,52 @@ def test_check_feedback_exists(mock_table, mock_env):
     assert result is False
 
 
+@patch("app.slack.slack_events.table")
+@patch("time.time")
+def test_store_feedback_no_message_ts_fallback(mock_time, mock_table, mock_env):
+    """Test store_feedback fallback path when no message_ts"""
+    mock_time.return_value = 1000
+    from app.slack.slack_events import store_feedback
+
+    with patch("app.slack.slack_events.get_latest_message_ts", return_value=None):
+        store_feedback("conv-key", "query", "positive", "user-id", "channel-id")
+        mock_table.put_item.assert_called_once()
+        # Should use fallback pk/sk format without condition
+        call_args = mock_table.put_item.call_args[1]
+        assert "ConditionExpression" not in call_args
+        item = call_args["Item"]
+        assert item["pk"] == "feedback#conv-key"
+        assert "#note#" in item["sk"]
+
+
+@patch("app.slack.slack_events.table")
+@patch("time.time")
+def test_store_conversation_session_with_thread(mock_time, mock_table, mock_env):
+    """Test store_conversation_session with thread_ts"""
+    mock_time.return_value = 1000
+    from app.slack.slack_events import store_conversation_session
+
+    store_conversation_session("conv-key", "session-id", "user-id", "channel-id", "thread-123", "msg-456")
+    mock_table.put_item.assert_called_once()
+    item = mock_table.put_item.call_args[1]["Item"]
+    assert item["thread_ts"] == "thread-123"
+    assert item["latest_message_ts"] == "msg-456"
+
+
+@patch("app.slack.slack_events.table")
+@patch("time.time")
+def test_store_conversation_session_without_thread(mock_time, mock_table, mock_env):
+    """Test store_conversation_session without thread_ts"""
+    mock_time.return_value = 1000
+    from app.slack.slack_events import store_conversation_session
+
+    store_conversation_session("conv-key", "session-id", "user-id", "channel-id")
+    mock_table.put_item.assert_called_once()
+    item = mock_table.put_item.call_args[1]["Item"]
+    assert "thread_ts" not in item
+    assert "latest_message_ts" not in item
+
+
 @patch("app.slack.slack_events.table")
 def test_cleanup_previous_unfeedback_qa_error_handling(mock_table, mock_env):
     """Test cleanup_previous_unfeedback_qa error handling"""
@@ -215,3 +261,28 @@ def test_store_feedback_client_error_reraise(mock_table, mock_env):
     with patch("app.slack.slack_events.get_latest_message_ts", return_value="123"):
         with pytest.raises(ClientError):
             store_feedback("conv-key", "query", "positive", "user-id", "channel-id")
+
+
+def test_feedback_text_extraction(mock_env):
+    """Test feedback text extraction logic"""
+    # Test the specific logic: note = text.split(":", 1)[1].strip() if ":" in text else ""
+
+    # Test with colon - should extract text after colon
+    text = "feedback: some feedback text"
+    note = text.split(":", 1)[1].strip() if ":" in text else ""
+    assert note == "some feedback text"
+
+    # Test without colon - should use empty string
+    text = "feedback"
+    note = text.split(":", 1)[1].strip() if ":" in text else ""
+    assert note == ""
+
+    # Test with colon but no text after
+    text = "feedback:"
+    note = text.split(":", 1)[1].strip() if ":" in text else ""
+    assert note == ""
+
+    # Test with colon and whitespace
+    text = "feedback:   "
+    note = text.split(":", 1)[1].strip() if ":" in text else ""
+    assert note == ""

packages/slackBotFunction/tests/test_slack_handlers.py

@@ -1,4 +1,6 @@
 import pytest
+import json
+import sys
 from unittest.mock import Mock, patch
 import os
 from botocore.exceptions import ClientError
@@ -511,3 +513,37 @@ def test_feedback_handler_storage_error(mock_env):
     ):
         feedback_handler(mock_ack, mock_body, mock_client)
         mock_ack.assert_called_once()
+
+
+@patch("slack_bolt.App")
+@patch("aws_lambda_powertools.utilities.parameters.get_parameter")
+@patch("boto3.resource")
+def test_is_latest_message_logic(mock_boto_resource, mock_get_parameter, mock_app, mock_env):
+    """Test _is_latest_message function logic"""
+    mock_get_parameter.side_effect = [
+        json.dumps({"token": "test-token"}),
+        json.dumps({"secret": "test-secret"}),
+    ]
+    mock_boto_resource.return_value.Table.return_value = Mock()
+
+    if "app.slack.slack_handlers" in sys.modules:
+        del sys.modules["app.slack.slack_handlers"]
+
+    from app.slack.slack_handlers import _is_latest_message
+
+    with patch("app.slack.slack_handlers.table") as mock_table:
+        # Test with matching message_ts
+        mock_table.get_item.return_value = {"Item": {"latest_message_ts": "123"}}
+        assert _is_latest_message("conv-key", "123") is True
+
+        # Test with non-matching message_ts
+        mock_table.get_item.return_value = {"Item": {"latest_message_ts": "456"}}
+        assert _is_latest_message("conv-key", "123") is False
+
+        # Test with no Item in response
+        mock_table.get_item.return_value = {}
+        assert _is_latest_message("conv-key", "123") is False
+
+        # Test with exception
+        mock_table.get_item.side_effect = Exception("DB error")
+        assert _is_latest_message("conv-key", "123") is False