tidy

Author: nhsdevws

backend/src/constants.py

@@ -24,4 +24,5 @@ class Urls:
 
 GENERIC_SERVER_ERROR_DIAGNOSTICS_MESSAGE = "Unable to process request. Issue may be transient."
 
-VACCINE_TYPE_TO_DISEASES_HASH_KEY = "vacc_to_diseases"
+VACCINE_TYPE_TO_DISEASES_HASH_KEY = "vacc_to_diseases"
+DISEASES_TO_VACCINE_TYPE_HASH_KEY = "diseases_to_vacc"

backend/src/models/utils/validation_utils.py

@@ -9,9 +9,8 @@
 from models.obtain_field_value import ObtainFieldValue
 from models.field_names import FieldNames
 from models.errors import MandatoryError
-from constants import Urls
+from constants import Urls, DISEASES_TO_VACCINE_TYPE_HASH_KEY
 from clients import redis_client
-from unittest.mock import Mock
 
 
 def get_target_disease_codes(immunization: dict):
@@ -54,7 +53,7 @@ def convert_disease_codes_to_vaccine_type(disease_codes_input: list) -> Union[st
     otherwise raises a value error
     """
     key = ":".join(sorted(disease_codes_input))
-    vaccine_type = redis_client.hget("diseases_to_vacc", key)
+    vaccine_type = redis_client.hget(DISEASES_TO_VACCINE_TYPE_HASH_KEY, key)
 
     if not vaccine_type:
         raise ValueError(