VED-736: refactor search response to avoid getting no response2

Author: Akol125

backend/src/fhir_service.py

@@ -69,8 +69,7 @@ def get_immunization_by_identifier(
         )
 
         patient_full_url = f"urn:uuid:{str(uuid4())}"
-        imms_list = [imms_resp] if isinstance(imms_resp, dict) else list(imms_resp or [])
-        filtered_response = [Filter.search(imms, patient_full_url) for imms in imms_list]
+        filtered_response = [Filter.search(imms, patient_full_url) for imms in imms_resp]
 
         if not filtered_response:
             base_url = f"{get_service_url()}/Immunization"

backend/tests/test_fhir_service.py

@@ -339,9 +339,11 @@ def test_get_immunization_by_identifier(self):
     def test_immunization_not_found(self):
         """it should return None if Immunization doesn't exist"""
         imms_id = "none"
+        imms_ids = ["imms-1", "imms-2"]
         identifier = "test"
         element = "id"
-        self.imms_repo.get_immunization_by_identifier.return_value = None
+        imms_list = [create_covid_19_immunization_dict(imms_id) for imms_id in imms_ids]
+        self.imms_repo.find_immunizations.return_value = deepcopy(imms_list)
 
         # When
         act_imms = self.fhir_service.get_immunization_by_identifier(imms_id, "COVID19.S", identifier, element)