Switch to Ruff for Python linting and formatting. (#898)

* Remove old linting code. Add Terraform to tool versions file for asdf / mise users.

* Update quality checks pipeline.

* Update dist included files.

* Remove unnecessary pipeline step and template.

* Reinstate .terraform-version while we're still using APIM pipelines.

* Switch to Ruff for Python linting and formatting.

* Auto apply safe fixes on commit.

* Attempt to fix first-party import detection.

* Revert failed attempt. Specify target Python version and apply automatic fixes.

Author: mfjarvis

backend/src/authorisation/authoriser.py

@@ -3,7 +3,7 @@
 import json
 
 from authorisation.api_operation_code import ApiOperationCode
-from clients import redis_client, logger
+from clients import logger, redis_client
 from constants import SUPPLIER_PERMISSIONS_HASH_KEY
 
 

backend/src/controller/aws_apig_event_utils.py

@@ -3,7 +3,6 @@
 from typing import Optional
 
 from aws_lambda_typing.events import APIGatewayProxyEventV1
-
 from controller.constants import SUPPLIER_SYSTEM_HEADER_NAME
 from models.errors import UnauthorizedError
 from utils import dict_utils

backend/src/controller/fhir_api_exception_handler.py

@@ -8,12 +8,12 @@
 from constants import GENERIC_SERVER_ERROR_DIAGNOSTICS_MESSAGE
 from controller.aws_apig_response_utils import create_response
 from models.errors import (
-    UnauthorizedVaxError,
-    UnauthorizedError,
+    Code,
     ResourceNotFoundError,
-    create_operation_outcome,
     Severity,
-    Code,
+    UnauthorizedError,
+    UnauthorizedVaxError,
+    create_operation_outcome,
 )
 
 _CUSTOM_EXCEPTION_TO_STATUS_MAP: dict[Type[Exception], int] = {

backend/src/controller/fhir_controller.py

@@ -8,28 +8,27 @@
 from typing import Optional
 
 from aws_lambda_typing.events import APIGatewayProxyEventV1
-
 from controller.aws_apig_event_utils import (
-    get_supplier_system_header,
     get_path_parameter,
+    get_supplier_system_header,
 )
 from controller.aws_apig_response_utils import create_response
 from controller.constants import E_TAG_HEADER_NAME
 from controller.fhir_api_exception_handler import fhir_api_exception_handler
 from models.errors import (
-    Severity,
     Code,
-    create_operation_outcome,
-    UnauthorizedError,
-    ResourceNotFoundError,
-    UnhandledResponseError,
-    ValidationError,
     IdentifierDuplicationError,
     ParameterException,
+    ResourceNotFoundError,
+    Severity,
+    UnauthorizedError,
     UnauthorizedVaxError,
+    UnhandledResponseError,
+    ValidationError,
+    create_operation_outcome,
 )
 from models.utils.generic_utils import check_keys_in_sources
-from parameter_parser import process_params, process_search_params, create_query_string
+from parameter_parser import create_query_string, process_params, process_search_params
 from repository.fhir_repository import ImmunizationRepository, create_table
 from service.fhir_service import FhirService, UpdateOutcome, get_service_url
 

backend/src/create_imms_handler.py

@@ -8,7 +8,7 @@
 from controller.fhir_controller import FhirController, make_controller
 from local_lambda import load_string
 from log_structure import function_info
-from models.errors import Severity, Code, create_operation_outcome
+from models.errors import Code, Severity, create_operation_outcome
 
 logging.basicConfig(level="INFO")
 logger = logging.getLogger()

backend/src/delete_imms_handler.py

@@ -7,7 +7,7 @@
 from controller.aws_apig_response_utils import create_response
 from controller.fhir_controller import FhirController, make_controller
 from log_structure import function_info
-from models.errors import Severity, Code, create_operation_outcome
+from models.errors import Code, Severity, create_operation_outcome
 
 logging.basicConfig(level="INFO")
 logger = logging.getLogger()

backend/src/filter.py

@@ -2,9 +2,9 @@
 
 from constants import Urls
 from models.utils.generic_utils import (
-    is_actor_referencing_contained_resource,
-    get_contained_practitioner,
     get_contained_patient,
+    get_contained_practitioner,
+    is_actor_referencing_contained_resource,
 )
 
 
@@ -63,7 +63,6 @@ def replace_organization_values(imms: dict) -> dict:
     """
     for performer in imms.get("performer", [{}]):
         if performer.get("actor", {}).get("type") == "Organization":
-
             # Obfuscate or set the identifier value and system.
             identifier = performer["actor"].get("identifier", {})
             if identifier.get("value") is not None:

backend/src/forwarding_batch_lambda.py

@@ -7,20 +7,19 @@
 from datetime import datetime
 
 import simplejson as json
-
 from batch.batch_filename_to_events_mapper import BatchFilenameToEventsMapper
 from clients import sqs_client
 from controller.fhir_batch_controller import (
     ImmunizationBatchController,
     make_batch_controller,
 )
 from models.errors import (
-    MessageNotSuccessfulError,
-    RecordProcessorError,
     CustomValidationError,
     IdentifierDuplicationError,
-    ResourceNotFoundError,
+    MessageNotSuccessfulError,
+    RecordProcessorError,
     ResourceFoundError,
+    ResourceNotFoundError,
 )
 from repository.fhir_batch_repository import create_table
 

backend/src/models/fhir_immunization.py

@@ -1,7 +1,6 @@
 """Immunization FHIR R4B validator"""
 
 from fhir.resources.R4B.immunization import Immunization
-
 from models.fhir_immunization_post_validators import PostValidators
 from models.fhir_immunization_pre_validators import PreValidators
 from models.utils.validation_utils import get_vaccine_type

backend/src/models/fhir_immunization_post_validators.py

@@ -4,7 +4,7 @@
 from models.field_locations import FieldLocations
 from models.field_names import FieldNames
 from models.mandation_functions import MandationFunctions
-from models.utils.base_utils import obtain_field_value, obtain_field_location
+from models.utils.base_utils import obtain_field_location, obtain_field_value
 from models.validation_sets import ValidationSets