removed batch_start_time

Author: JamesW1-NHS

ack_backend/src/logging_decorators.py

@@ -58,7 +58,6 @@ def wrapper(message, created_at_formatted_string):
             additional_log_data = {
                 "file_key": file_key,
                 "message_id": message_id,
-                "batch_start_time": message.get("batch_start_time", "unknown"),
                 "operation_start_time": message.get("operation_start_time", "unknown"),
                 "operation_end_time": message.get("operation_end_time", "unknown"),
                 "vaccine_type": message.get("vaccine_type", "unknown"),

ack_backend/tests/utils/values_for_ack_backend_tests.py

@@ -16,7 +16,6 @@ class DefaultValues:
     imms_id = "test_imms_id"
     operation_requested = "CREATE"
     created_at_formatted_string = "20211120T12000000"
-    batch_start_time = fixed_datetime_str
     operation_start_time = fixed_datetime_str
     operation_end_time = fixed_datetime_str
 
@@ -96,7 +95,6 @@ def __init__(
         local_id: str = DefaultValues.local_id,
         imms_id: str = DefaultValues.imms_id,
         created_at_formatted_string: str = DefaultValues.created_at_formatted_string,
-        batch_start_time: str = DefaultValues.batch_start_time,
         operation_start_time: str = DefaultValues.operation_start_time,
         operation_end_time: str = DefaultValues.operation_end_time,
     ):
@@ -117,7 +115,6 @@ def __init__(
         self.local_id = local_id
         self.imms_id = imms_id
         self.created_at_formatted_string = created_at_formatted_string
-        self.batch_start_time= batch_start_time
         self.operation_start_time = operation_start_time
         self.operation_end_time = operation_end_time
 
@@ -128,7 +125,6 @@ def __init__(
             "supplier": self.supplier,
             "vaccine_type": self.vaccine_type,
             "created_at_formatted_string": self.created_at_formatted_string,
-            "batch_start_time": self.batch_start_time,
             "operation_start_time": self.operation_start_time,
             "operation_end_time": self.operation_end_time,
             "row_id": self.row_id,
@@ -166,7 +162,6 @@ class ValidValues:
     mock_message_expected_log_value = {
         "function_name": "ack_processor_convert_message_to_ack_row",
         "date_time": fixed_datetime.strftime("%Y-%m-%d %H:%M:%S"),
-        "batch_start_time": MOCK_MESSAGE_DETAILS.batch_start_time,
         "operation_start_time": MOCK_MESSAGE_DETAILS.operation_start_time,
         "operation_end_time": MOCK_MESSAGE_DETAILS.operation_end_time,
         "status": "success",
@@ -260,7 +255,6 @@ class InvalidValues:
     Logging_with_no_values = {
         "function_name": "ack_processor_convert_message_to_ack_row",
         "date_time": fixed_datetime.strftime("%Y-%m-%d %H:%M:%S"),
-        "batch_start_time": "unknown",
         "operation_start_time": "unknown",
         "operation_end_time": "unknown",
         "status": "fail",

backend/src/forwarding_batch_lambda.py

@@ -61,7 +61,6 @@ def forward_request_to_dynamo(
 def forward_lambda_handler(event, _):
     """Forward each row to the Imms API"""
     logger.info("Processing started")
-    batch_start_time = str(datetime.now())
     table = create_table()
     filename_to_events_mapper = BatchFilenameToEventsMapper()
     array_of_identifiers = []
@@ -108,7 +107,6 @@ def forward_lambda_handler(event, _):
             imms_id = forward_request_to_dynamo(incoming_message_body, table, identifier_already_present, controller)
             filename_to_events_mapper.add_event(
                 { **base_outgoing_message_body,
-                 "batch_start_time": batch_start_time,
                  "operation_start_time": operation_start_time,
                  "operation_end_time": str(datetime.now()),
                  "imms_id": imms_id }
@@ -117,7 +115,6 @@ def forward_lambda_handler(event, _):
         except Exception as error:  # pylint: disable = broad-exception-caught
             filename_to_events_mapper.add_event(
                 { **base_outgoing_message_body,
-                 "batch_start_time": batch_start_time,
                  "operation_start_time": operation_start_time,
                  "operation_end_time": str(datetime.now()),
                  "diagnostics": create_diagnostics_dictionary(error) }

backend/tests/test_forwarding_batch_lambda.py

@@ -455,7 +455,6 @@ def test_forward_lambda_handler_groups_and_sends_events_by_filename(self, mock_s
         self.assertDictEqual(json.loads(first_call_kwargs["MessageBody"])[0], {
             "created_at_formatted_string": "2025-01-24T12:00:00Z",
             "file_key": "supplier_1_rsv_test_file",
-            "batch_start_time": ANY,
             "operation_start_time": ANY,
             "operation_end_time": ANY,
             "imms_id": ANY,
@@ -468,7 +467,6 @@ def test_forward_lambda_handler_groups_and_sends_events_by_filename(self, mock_s
         self.assertDictEqual(json.loads(second_call_kwargs["MessageBody"])[0], {
             "created_at_formatted_string": "2025-01-24T12:00:00Z",
             "file_key": "supplier_2_rsv_test_file",
-            "batch_start_time": ANY,
             "operation_start_time": ANY,
             "operation_end_time": ANY,
             "imms_id": ANY,