Merged
Conversation
Contributor
|
This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket: VED-934 |
|
Akol125
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
Akol125
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
edhall-nhs
reviewed
Nov 26, 2025
| raise ParameterExceptionError( | ||
| f"Search parameter {ImmunizationSearchParameterName.DATE_FROM} may have one value at most." | ||
| ) | ||
| errors.append(f"Search parameter {ImmunizationSearchParameterName.DATE_FROM} may have one value at most.") |
Contributor
There was a problem hiding this comment.
I would check with Krupa if these messages need to be appended of if they need to be on their own. Only because they're not mentioned in the ticket
edhall-nhs
reviewed
Nov 26, 2025
| ) | ||
| include = includes[0] | ||
|
|
||
| if errors: |
Contributor
There was a problem hiding this comment.
Might be clearer to be explicit here and check if the length of the list != 0. This is subjective though.
Contributor
There was a problem hiding this comment.
It works for both None and []
JamesW1-NHS
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add any other relevant notes or explanations here. Remove this line if you have nothing to add.
Reviews Required
Review Checklist
ℹ️ This section is to be filled in by the reviewer.