VED-948: Data Quality Skeleton#1059
Merged
edhall-nhs merged 4 commits intostaging/VED-963-data-quality-reportsfrom Dec 18, 2025
Merged
VED-948: Data Quality Skeleton#1059edhall-nhs merged 4 commits intostaging/VED-963-data-quality-reportsfrom
edhall-nhs merged 4 commits intostaging/VED-963-data-quality-reportsfrom
Conversation
Contributor
|
This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket: VED-948 |
edhall-nhs
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
edhall-nhs
had a problem deploying
to
internal-dev-sandbox
GitHub Actions
Error
edhall-nhs
had a problem deploying
to
internal-dev
GitHub Actions
Failure
edhall-nhs
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
edhall-nhs
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
edhall-nhs
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
edhall-nhs
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
edhall-nhs
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
edhall-nhs
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
edhall-nhs
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
edhall-nhs
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
edhall-nhs
had a problem deploying
to
internal-dev
GitHub Actions
Failure
edhall-nhs
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
edhall-nhs
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
|
edhall-nhs
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
edhall-nhs
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
edhall-nhs
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
edhall-nhs
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
edhall-nhs
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
dlzhry2nhs
approved these changes
Dec 18, 2025
dlzhry2nhs
reviewed
Dec 18, 2025
|
|
||
|
|
||
| class DataQualityChecker: | ||
| """Runs data quality checks against an Immunisation and creates a Data Quality Output object""" |
Collaborator
There was a problem hiding this comment.
We may also want a module docstring, or more detail in the class docstring explaining what, why and for whose benefit this exists. But can defer it until after the main implementation, as it is documentation.
Contributor
Author
There was a problem hiding this comment.
Yeah we can defer this 👍 in case anything changes during implementation
edhall-nhs
changed the title
edhall-nhs
merged commit 05011b0
into
staging/VED-963-data-quality-reports
17 checks passed
dlzhry2nhs
pushed a commit
that referenced
this pull request
Dec 19, 2025
* Move delta converter to shared code * Refactor and move tests into shared * Move and rename converter files and tests * Add basic structure for Data Quality Checker
dlzhry2nhs
pushed a commit
that referenced
this pull request
Dec 29, 2025
* Move delta converter to shared code * Refactor and move tests into shared * Move and rename converter files and tests * Add basic structure for Data Quality Checker
dlzhry2nhs
pushed a commit
that referenced
this pull request
Jan 6, 2026
* Move delta converter to shared code * Refactor and move tests into shared * Move and rename converter files and tests * Add basic structure for Data Quality Checker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes the framework for the remainder of the initial Data Quality work. As well as moving the delta converter into the common code so it can be used for DQ checks.
Reviews Required
Review Checklist
ℹ️ This section is to be filled in by the reviewer.