Skip to content

VED-887: Slack Api Error Alerting#1066

Merged
Akol125 merged 14 commits intomasterfrom
VED-887-Slack-alerting-API-errors
Dec 18, 2025
Merged

VED-887: Slack Api Error Alerting#1066
Akol125 merged 14 commits intomasterfrom
VED-887-Slack-alerting-API-errors

Conversation

@Akol125
Copy link
Contributor

@Akol125 Akol125 commented Dec 15, 2025

Summary

  • Routine Change
  • ❗ Breaking Change
  • 🤖 Operational or Infrastructure Change
  • ✨ New Feature
  • ⚠️ Potential issues that might be caused by this change

Add any other relevant notes or explanations here. Remove this line if you have nothing to add.

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all of the acceptance criteria of the ticket.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • If there were changes that are outside of the regular release processes e.g. account infrastructure to setup, manual setup for external API integrations, secrets to set, then I have checked that the developer has flagged this to the Tech Lead as release steps.
  • I have checked that no Personal Identifiable Data (PID) is logged as part of the changes.

@github-actions
Copy link
Contributor

This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket:

VED-887

Copy link
Collaborator

@dlzhry2nhs dlzhry2nhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tidyness change, and one bit of naming that needs updating as the alarms will not work with the current configuration.

dlzhry2nhs
dlzhry2nhs previously approved these changes Dec 18, 2025
Copy link
Collaborator

@dlzhry2nhs dlzhry2nhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - nice work :)

@sonarqubecloud
Copy link

@Akol125 Akol125 temporarily deployed to internal-dev-sandbox December 18, 2025 14:28 — with GitHub Actions Inactive
@Akol125 Akol125 merged commit 6650a62 into master Dec 18, 2025
17 checks passed
@Akol125 Akol125 deleted the VED-887-Slack-alerting-API-errors branch December 18, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments