Skip to content

VED-73- drop obfuscation for s-flag-patient #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Akol125 merged 3 commits into from
Mar 24, 2025
Merged

VED-73- drop obfuscation for s-flag-patient #353

Akol125 merged 3 commits into from
Mar 24, 2025

Conversation

@Akol125
Copy link
Contributor

@Akol125 Akol125 commented Mar 11, 2025 •
edited by krupasindhubaral
Loading

❗ Breaking Change: Remove S-flagged obfuscation for read requests

  • Exposes previously obfuscated fields
  • Ensures full Immunization resources are returned for s-flagged patients on read requests
  • Ensures responses are FHIR valid and works as is

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the changelog has been updated by the submitter, if necessary.

@Akol125 Akol125 requested a review from AlexandraBenson March 11, 2025 23:05
@nhsdevws nhsdevws self-requested a review March 12, 2025 09:59
nhsdevws
nhsdevws suggested changes Mar 13, 2025
View reviewed changes
Copy link
Contributor

@nhsdevws nhsdevws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleanup new whitespace. Remove s-flag references. Bad indentation

@Akol125 Akol125 removed the request for review from AlexandraBenson March 13, 2025 17:15
@Akol125 Akol125 closed this Mar 14, 2025
@Akol125 Akol125 reopened this Mar 14, 2025
@Akol125 Akol125 changed the title READ request- drop obfuscation for s-flag patient VED-73- drop obfuscation for s-flag-patient Mar 14, 2025
@Akol125 Akol125 closed this Mar 16, 2025
@Akol125 Akol125 reopened this Mar 16, 2025
@Akol125 Akol125 requested a review from nhsdevws March 17, 2025 17:58
nhsdevws
nhsdevws previously approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@nhsdevws nhsdevws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backend/.gitignore has an irrelevent entry terraform.tfstate

@robertnovac1 robertnovac1 force-pushed the VED-73-Read-S-flag-obfuscation branch 4 times, most recently from b15fe7e to f278fb8 Compare March 19, 2025 09:16
Akol125 and others added 2 commits March 19, 2025 09:17
@Akol125 @robertnovac1
parent 0719a0d
f278fb8 
author Akol125 <[email protected]> 1741732167 +0000
committer Robert Novac <[email protected]> 1742314388 +0000

READ request- drop obfuscation for s-flag patient
@robertnovac1
spacing removed
07d66f8
@Akol125 Akol125 requested review from saptarshimandal1 and removed request for saptarshimandal1 March 19, 2025 16:09
saptarshimandal1
saptarshimandal1 approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@saptarshimandal1 saptarshimandal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 21, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Akol125 Akol125 merged commit 55cbf76 into master Mar 24, 2025
8 checks passed
@Valswyn-NHS Valswyn-NHS mentioned this pull request Mar 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saptarshimandal1 saptarshimandal1 saptarshimandal1 approved these changes

+2 more reviewers

@nhsdevws nhsdevws nhsdevws approved these changes

@robertnovac1 robertnovac1 robertnovac1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Akol125 Akol125

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Akol125 @saptarshimandal1 @nhsdevws @robertnovac1