Conversation
nhsdevws
force-pushed
the
VED-169-Delta-Multi-Rec
branch
from
788408a to
344b7b7
Compare
nhsdevws
force-pushed
the
VED-169-Delta-Multi-Rec
branch
from
58505d0 to
1580a4b
Compare
mfjarvis
reviewed
May 14, 2025
delta_backend/tests/test_delta.py
Outdated
| self.assertTrue(result) | ||
|
|
||
| @patch("boto3.resource") | ||
| def test_handler_success_remove(self, mock_boto_resource): |
Contributor
There was a problem hiding this comment.
Looks like this is meant to be testing the REMOVE case and the extra asserts should be added to test_handler_success_update instead
Contributor
Author
There was a problem hiding this comment.
@mfjarvis this has been addressed along with new test for PHYSICAL DELETE / REMOVE
mfjarvis
reviewed
May 14, 2025
nhsdevws
force-pushed
the
VED-169-Delta-Multi-Rec
branch
from
8a011d8 to
aa8035f
Compare
nhsdevws
force-pushed
the
VED-169-Delta-Multi-Rec
branch
from
baaefb2 to
5caa193
Compare
|
mfjarvis
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JIRA: https://nhsd-jira.digital.nhs.uk/browse/VED-169
Changes:
Reviews Required
Review Checklist
ℹ️ This section is to be filled in by the reviewer.