Conversation
|
Akol125
changed the title
nhsdevws
reviewed
May 29, 2025
| "- 'YYYY-MM-DDThh:mm:ss%z' — Full date and time with timezone (e.g. +00:00 or +01:00)\n" | ||
| "- 'YYYY-MM-DDThh:mm:ss.f%z' — Full date and time with milliseconds and timezone\n\n" | ||
| "Only '+00:00' and '+01:00' are accepted as valid timezone offsets.\n" | ||
| f"{field_location} must be a valid datetime in one of the following formats:" |
nhsdevws
reviewed
May 29, 2025
| "- 'YYYY-MM-DDThh:mm:ss.f%z' — Full date and time with milliseconds and timezone\n\n" | ||
| "Only '+00:00' and '+01:00' are accepted as valid timezone offsets.\n" | ||
| f"{field_location} must be a valid datetime in one of the following formats:" | ||
| "- 'YYYY-MM-DD' — Full date only" |
nhsdevws
reviewed
May 29, 2025
nhsdevws
reviewed
May 29, 2025
nhsdevws
reviewed
May 29, 2025
|
|
||
| if not (valid_addresses := [ | ||
| addr for addr in addresses | ||
| if addr.get("postalCode") and self._is_current_period(addr, occurrence_time) |
Contributor
|
Not sure I agree with |
Contributor
|
The possible values of |
Contributor
|
If we wanted to enforce that we were only ever reading from valid FHIR fields, then I'd suggest using model classes like the ones provided by the fhir.resources package. But doing that would also add some avoidable overhead to something which needs to run fairly fast |
mfjarvis
approved these changes
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add any other relevant notes or explanations here. Remove this line if you have nothing to add.
Reviews Required
Review Checklist
ℹ️ This section is to be filled in by the reviewer.