Skip to content

Conversation

@mfjarvis
Copy link
Contributor

@mfjarvis mfjarvis commented May 29, 2025

Summary

  • Routine Change
  • 🤖 Operational or Infrastructure Change

Improve our SonarCloud pipeline by creating a venv for each subproject and installing dependencies using poetry. This ensures that we run the tests with the same dependencies and dependency versions as will be available to the deployed code.

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the changelog has been updated by the submitter, if necessary.

@mfjarvis mfjarvis force-pushed the VED-305-matt-testing branch from 85419d7 to 3bdca02 Compare May 30, 2025 00:45
@nhsdevws nhsdevws force-pushed the VED-305-matt-testing branch 2 times, most recently from 5f9c75e to bd2c65b Compare May 30, 2025 13:43
@mfjarvis mfjarvis changed the title VED-305: Matt's test branch VED-305: Run SonarCloud unit tests in isolated environments. Jun 3, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 3, 2025


- uses: actions/setup-python@v5
with:
python-version: |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this valid syntax?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mfjarvis mfjarvis merged commit 61a2750 into master Jun 3, 2025
8 checks passed
@mfjarvis mfjarvis deleted the VED-305-matt-testing branch June 3, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants