Skip to content

VED 369 Redis Sync firehose logging#610

Merged
nhsdevws merged 10 commits intomasterfrom
VED-369-Redis-Sync-Firehose-Logging
Jun 26, 2025
Merged

VED 369 Redis Sync firehose logging#610
nhsdevws merged 10 commits intomasterfrom
VED-369-Redis-Sync-Firehose-Logging

Conversation

@nhsdevws
Copy link
Contributor

@nhsdevws nhsdevws commented Jun 24, 2025

Summary

  • Routine Change
  • ❗ Breaking Change
  • 🤖 Operational or Infrastructure Change
  • ✨ New Feature
  • ⚠️ Potential issues that might be caused by this change

VED-369 Config upload Splunk Firehose
Description Add logging to firehose to the redis-sync lambda
****

Notes:

  • Decorator used as per filenameprocessor, recordprocessor, ack_backend and redis_sync modules
  • TODO added to move code to sharable module
  • duplicate code exclusion added to sonarqube
  • PR 610 VED 369 Redis Sync firehose logging #610

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the changelog has been updated by the submitter, if necessary.

@nhsdevws nhsdevws self-assigned this Jun 25, 2025
@nhsdevws nhsdevws enabled auto-merge (squash) June 25, 2025 11:49
sonar.host.url=https://sonarcloud.io
sonar.python.version=3.11
sonar.exclusions=**/e2e/**,**/e2e_batch/**,**/temporary_sandbox/**,**/devtools/**,**/proxies/**,**/scripts/**,**/terraform/**,**/tests/**
sonar.exclusions=**/e2e/**,**/e2e_batch/**,**/temporary_sandbox/**,**/devtools/**,**/proxies/**,**/scripts/**,**/terraform/**,**/tests/**,redis_sync/src/log_decorator.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's probably a way to mark an error as fine to ignore in the Sonar UI itself. Might be better if I do that so we don't forget to remove this exclusion later on

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying the #NOSONAR tag

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#NOSONAR tag seems to be an AI hallucination. Search of t'internet suggests it is not possible to suppress locally. So, I have added a TODO to the comment that it can be removed when the code is relocated for reuse

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry, I meant if you remove this exclusion I can probably go into the Sonar UI and ignore it there, no code change needed.

@nhsdevws nhsdevws force-pushed the VED-369-Redis-Sync-Firehose-Logging branch from 59f6d46 to 30b474e Compare June 25, 2025 16:32
@sonarqubecloud
Copy link

@nhsdevws nhsdevws merged commit 9fe60d3 into master Jun 26, 2025
8 checks passed
@nhsdevws nhsdevws deleted the VED-369-Redis-Sync-Firehose-Logging branch June 26, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants