Skip to content

VED-458 Terraform folder restructure #651

Merged
robertnovac1 merged 23 commits intomasterfrom
VED-357-terraform-folder-changes-only
Jul 23, 2025
Merged

VED-458 Terraform folder restructure #651
robertnovac1 merged 23 commits intomasterfrom
VED-357-terraform-folder-changes-only

Conversation

@robertnovac1
Copy link
Contributor

@robertnovac1 robertnovac1 commented Jul 11, 2025 •
edited
Loading

Summary

  • Routine Change
  • 🤖 Operational or Infrastructure Change
  • ⚠️ Potential issues that might be caused by this change

Changes:

  • Updated terraform to use separate folders for environment specific configuration
  • Moved environment specific configuration outside core terraform logic
  • Updated Makefile to read configuration from .env and the pipeline parameters
  • Updated README.MD
  • Removed unused variables and resources

Reviews Required

  • Dev

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the changelog has been updated by the submitter, if necessary.

@robertnovac1 robertnovac1 changed the title Ved 357 terraform folder changes only VED 458 terraform folder changes only Jul 14, 2025
@robertnovac1 robertnovac1 changed the title VED 458 terraform folder changes only VED-458 Terraform folder restructure Jul 16, 2025
robertnovac1
robertnovac1 commented Jul 16, 2025
View reviewed changes
robertnovac1
robertnovac1 commented Jul 16, 2025
View reviewed changes
robertnovac1
robertnovac1 commented Jul 16, 2025
View reviewed changes
robertnovac1
robertnovac1 commented Jul 16, 2025
View reviewed changes
robertnovac1
robertnovac1 commented Jul 16, 2025
View reviewed changes
robertnovac1
robertnovac1 commented Jul 16, 2025
View reviewed changes
robertnovac1
robertnovac1 commented Jul 16, 2025
View reviewed changes
robertnovac1
robertnovac1 commented Jul 16, 2025
View reviewed changes
@robertnovac1 robertnovac1 requested a review from mfjarvis July 17, 2025 08:31
mfjarvis
mfjarvis reviewed Jul 23, 2025
View reviewed changes
terraform/endpoints.tf Outdated
"DYNAMODB_TABLE_NAME" = local.imms_table_name,
"IMMUNIZATION_ENV" = local.environment,
"IMMUNIZATION_BASE_PATH" = strcontains(local.environment, "pr-") ? "immunisation-fhir-api-${local.environment}" : "immunisation-fhir-api"
"IMMUNIZATION_ENV" = var.sub_environment,
Copy link
Contributor

@mfjarvis mfjarvis Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be local.resource_scope

Copy link
Contributor Author

@robertnovac1 robertnovac1 Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorted

mfjarvis
mfjarvis reviewed Jul 23, 2025
View reviewed changes
mfjarvis
mfjarvis reviewed Jul 23, 2025
View reviewed changes
@robertnovac1 robertnovac1 enabled auto-merge (squash) July 23, 2025 10:07
@robertnovac1 robertnovac1 merged commit 305ef80 into master Jul 23, 2025
8 checks passed
@robertnovac1 robertnovac1 deleted the VED-357-terraform-folder-changes-only branch July 23, 2025 10:14
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 23, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfjarvis mfjarvis mfjarvis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@robertnovac1 @mfjarvis