Hotfix/ved 754 processor task cp1252 encoding

[nhsdevws]

Summary

• Hotfix Change

Addresses filename processor task - row processing encountering chars not utf-8.

Resolves:

• exception thrown if issue detected at header validation (small files)
• exception thrown if issue detected during iteration of DictReader (large files)

Note:

• small file tested with 3 rows. Large file tested with 1500 rows
• sonarcloud doesnt run unit tests. Unit tests pass run locally make test
• Changes only affect cp1252 files. utf-8 files run unhindered.

Reviews Required

• Dev
• Test
• Tech Author
• Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

• I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
• If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
• I have ensured the changelog has been updated by the submitter, if necessary.

[dlzhry2nhs]

Thanks so much for doing this. It will avoid us reading the file for validation and is a smarter solution.

I've added a handful of comments. The only things I think I'd really like to see would be handling for the specific exception and a comment to explain the rationale for the change more clearly.

[dlzhry2nhs]

Changing my remaining comments to advisory rather than Request changes so it does not block if someone approves over lunch.

Thanks for resolving so quickly.

Would be good to get a quick change in for the remaining 3 points.

[dlzhry2nhs]

Awesome work. Thanks for your patience and sorting them all out so quickly. As discussed offline there is a failing test locally (shame release branch does not have the pipeline fixes).

It's gonna be fixed, so approving now.

[sonarqubecloud]

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud