VED-714 (Addition) - Add info log and fix rare race condition#839
Merged
dlzhry2nhs merged 1 commit intomasterfrom Sep 22, 2025
Merged
Conversation
Contributor
|
This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket: VED-714 |
|
motola
approved these changes
Sep 22, 2025
Akol125
approved these changes
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Spotted an issue in the non-prod alerting channel. Have undertaken a couple of changes to make supporting the new Lambda a bit easier in future.
It is hard to replicate the issue as it is intermittent and requires a fair bit of traffic. However, I have seen circumstances where this happens when we have a lot of Medicus messages coming in at once.
Essentially if the batch filter Lambda is running hot, it could be that the filename proc lambda sends a message to SQS and this is picked up before it actually writes the batch table entry. As DDB is eventually consistent, this means that it might fail to retrieve the entry.
I therefore made a minor change to ensure it is created before sending to SQS.
Reviews Required
Review Checklist
ℹ️ This section is to be filled in by the reviewer.